From 22a46eb44016eec3384da3731a2d47a5d3c91955 Mon Sep 17 00:00:00 2001 From: J. Bruce Fields Date: Fri, 17 May 2019 16:22:18 -0400 Subject: nfsd: note inadequate stats locking After 89a26b3d295d "nfsd: split DRC global spinlock into per-bucket locks", there is no longer a single global spinlock to protect these stats. So, really we need to fix that. For now, at least fix the comment. Signed-off-by: J. Bruce Fields --- fs/nfsd/netns.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'fs/nfsd') diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h index 46240c4d9184..ceb413f8fff3 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h @@ -142,8 +142,11 @@ struct nfsd_net { unsigned int drc_hashsize; /* - * Stats and other tracking of on the duplicate reply cache. All of these and - * the "rc" fields in nfsdstats are protected by the cache_lock + * Stats and other tracking of on the duplicate reply cache. + * These fields and the "rc" fields in nfsdstats are modified + * with only the per-bucket cache lock, which isn't really safe + * and should be fixed if we want the statistics to be + * completely accurate. */ /* total number of entries */ -- cgit v1.2.3-55-g7522