diff options
| author | Karel Zak | 2009-10-16 21:49:33 +0200 |
|---|---|---|
| committer | Karel Zak | 2009-10-17 00:18:46 +0200 |
| commit | b2f15782a71fd7d89bed7b3e1f799358779ee828 (patch) | |
| tree | 0aa8a6148dc02d102aee300e19709f815902b90c /fdisk/fdiskaixlabel.c | |
| parent | Revert "build-sys: move fsck/mkfs for bfs/cramfs/minix to /usr" (diff) | |
| download | kernel-qcow2-util-linux-b2f15782a71fd7d89bed7b3e1f799358779ee828.tar.gz kernel-qcow2-util-linux-b2f15782a71fd7d89bed7b3e1f799358779ee828.tar.xz kernel-qcow2-util-linux-b2f15782a71fd7d89bed7b3e1f799358779ee828.zip | |
fdisk: fix strict-aliasing bugs
gcc 4.4 produces tons of
"dereferencing type-punned pointer will break strict-aliasing rules"
warnings for fdisk code where is
char buffer[BUFSIZ];
((struct disklabel *) MBRBuffer)->foo
There are two ways how fix the problem:
1/ union {
char buffer[BUFSIZ], struct disklabel label
} MBRBuffer;
2/ use allocated buffer, this way seems less invasive.
This patch implements 2/.
Old version:
$ make -C fdisk | grep -c warning
236
New version:
$ make -C fdisk | grep -c warning
0
About aliasing:
- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40665
- http://cellperformance.beyond3d.com/articles/2006/06/understanding-strict-aliasing.html
- C99
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'fdisk/fdiskaixlabel.c')
| -rw-r--r-- | fdisk/fdiskaixlabel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fdisk/fdiskaixlabel.c b/fdisk/fdiskaixlabel.c index 4f6167f97..e7ee95d1c 100644 --- a/fdisk/fdiskaixlabel.c +++ b/fdisk/fdiskaixlabel.c @@ -44,7 +44,7 @@ aix_nolabel( void ) aixlabel->magic = 0; aix_label = 0; partitions = 4; - memset( MBRbuffer, 0, sizeof(MBRbuffer) ); /* avoid fdisk cores */ + zeroize_mbr_buffer(); return; } |