summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* docs: update AUTHORS fileKarel Zak2015-08-241-0/+3
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* po: merge changesKarel Zak2015-08-2427-23713/+26497
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* po: update ja.po (from translationproject.org)Takeshi Hamasaki2015-08-241-4098/+3141Star
|
* po: update fi.po (from translationproject.org)Lauri Nurmi2015-08-241-3772/+2805Star
|
* tests: update static build testKarel Zak2015-08-241-0/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: add hint about chfn & chsh bug and thanks to qualysKarel Zak2015-08-241-0/+8
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libblkid: added drbdmanage control volume detection.Philipp Marek2015-08-246-0/+100
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* hwclock: fix iopl implicit declaration warning on alphaAndreas Henriksson2015-08-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | Build warning: sys-utils/hwclock-cmos.c: In function 'i386_iopl': sys-utils/hwclock-cmos.c:611:9: warning: implicit declaration of function 'iopl' [-Wimplicit-function-declaration] return iopl(level); ^ sys-utils/hwclock-cmos.c:611:2: warning: nested extern declaration of 'iopl' [-Wnested-externs] return iopl(level); ^ Also: checking sys/io.h usability... yes checking sys/io.h presence... yes checking for sys/io.h... yes Full build log: https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=alpha&ver=2.26.2-9&stamp=1440078034 Detected by/via: https://qa.debian.org/bls/packages/u/util-linux.html Please note that this has never been (build-)tested, but should hopefully resolve the warning. Signed-off-by: Andreas Henriksson <andreas@fatal.se>
* hwclock: fix fgets unchecked return value warning on alphaAndreas Henriksson2015-08-241-4/+4
| | | | | | | | | | | | | | | | | | Build warning: sys-utils/hwclock-cmos.c: In function 'is_in_cpuinfo': sys-utils/hwclock-cmos.c:162:4: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result] fgets(field, 256, cpuinfo); Full build log: https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=alpha&ver=2.26.2-9&stamp=1440078034 Detected by/via: https://qa.debian.org/bls/packages/u/util-linux.html This change has never actually been (build-)tested on alpha, but hopefully the change should fix the warning. Signed-off-by: Andreas Henriksson <andreas@fatal.se>
* hwclock: fix signed/unsigned comparison warning on alphaAndreas Henriksson2015-08-241-2/+2
| | | | | | | | | | | | | | | | | | | Fixes the following warning: sys-utils/hwclock.c: In function 'manipulate_epoch': sys-utils/hwclock.c:1465:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (epoch_opt == -1) Full build log available on: https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=alpha&ver=2.26.2-9&stamp=1440078034 Detected by/via: https://qa.debian.org/bls/packages/u/util-linux.html Please note that this has never actually been (build-)tested on alpha, but should hopefully resolve the warning. Note also that limits.h is already included. Signed-off-by: Andreas Henriksson <andreas@fatal.se>
* misc: fix shadow declarationsSami Kerola2015-08-243-11/+11
| | | | | | | | | | | | | | | | | | | | | | sys-utils/zramctl.c: In function 'get_mm_stat': sys-utils/zramctl.c:276:58: warning: declaration of 'inbytes' shadows a global declaration [-Wshadow] static char *get_mm_stat(struct zram *z, size_t idx, int inbytes) sys-utils/zramctl.c:119:39: note: shadowed declaration is here static unsigned int raw, no_headings, inbytes; libmount/src/tab.c: In function 'mnt_table_get_fs_root': libmount/src/tab.c:1221:22: warning: declaration of 'fs' shadows a parameter [-Wshadow] struct libmnt_fs *fs = mnt_table_find_mountpoint(tb, libmount/src/tab.c:1197:24: note: shadowed declaration is here struct libmnt_fs *fs, disk-utils/fsck.minix.c: In function 'main': disk-utils/fsck.minix.c:1364:17: warning: declaration of 'i' shadows a previous local [-Wshadow] unsigned long i, free; disk-utils/fsck.minix.c:1250:6: note: shadowed declaration is here int i; Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* chfn: document CHFN_RESTRICT /etc/login.defsKarel Zak2015-08-241-0/+26
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* chsh, chfn, vipw: fix filenames collisionKarel Zak2015-08-247-25/+20Star
| | | | | | | | | | | | | | | | | | The utils when compiled WITHOUT libuser then mkostemp()ing "/etc/%s.XXXXXX" where the filename prefix is argv[0] basename. An attacker could repeatedly execute the util with modified argv[0] and after many many attempts mkostemp() may generate suffix which makes sense. The result maybe temporary file with name like rc.status ld.so.preload or krb5.keytab, etc. Note that distros usually use libuser based ch{sh,fn} or stuff from shadow-utils. It's probably very minor security bug. Addresses: CVE-2015-5224 Signed-off-by: Karel Zak <kzak@redhat.com>
* tests: add blkid script to test whole-disk MBR devicesKarel Zak2015-08-213-0/+43
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libmount: (monitor) fix docsKarel Zak2015-08-191-1/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: update TODOKarel Zak2015-08-191-11/+0Star
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* Merge branch 'master' of https://github.com/FGrose/util-linuxKarel Zak2015-08-171-4/+4
|\ | | | | | | | | * 'master' of https://github.com/FGrose/util-linux: Fix typos in --target
| * Fix typos in --targetFrederick Grose2015-08-141-4/+4
| |
* | libmount: add support for "bind,ro"Karel Zak2015-08-173-20/+67
|/ | | | | | | | | | | | | | Now it's necessary t use two mount(8) calls to create a read-only mount: mount /foo /bar -o bind mount /bar -o remount,ro,bind This patch allows to specify "bind,ro" and the remount is done automatically by libmount by additional mount(2) syscall. It's not atomic of course. Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: add lsblk vs. btrfs to TODOKarel Zak2015-08-131-0/+7
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: add mount --namespace to TODOKarel Zak2015-08-131-0/+4
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* Merge branch 'colcrt' of git://github.com/kerolasa/lelux-utiliteetitKarel Zak2015-08-1211-15/+442
|\ | | | | | | | | | | | | | | | | | | * 'colcrt' of git://github.com/kerolasa/lelux-utiliteetit: tests: add colcrt regression tests colcrt: allocate enough space for data moves [afl & asan] colcrt: avoid writing beyond array bound [afl & asan] colcrt: use #define in place of magic constants misc: fix redundant assignment and reassignments before use [cppcheck] tools: stop checkmans.sh validating libtool builds
| * tests: add colcrt regression testsSami Kerola2015-08-106-0/+422
| | | | | | | | | | | | | | Thanks to Alaa Mubaied for providing crash1 input file making colcrt to crash. The crash2 was generated using American Fuzzy Lop. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * colcrt: allocate enough space for data moves [afl & asan]Sami Kerola2015-08-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ==2807==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000013a31f0 at pc 0x0000004e3047 bp 0x7fffcb7df8d0 sp 0x7fffcb7df8c8 READ of size 4 at 0x0000013a31f0 thread T0 #0 0x4e3046 in move /home/src/util-linux/text-utils/colcrt.c:309:13 #1 0x4e25b1 in pflush /home/src/util-linux/text-utils/colcrt.c:264:3 #2 0x4e246d in colcrt /home/src/util-linux/text-utils/colcrt.c:157:4 #3 0x4e17d4 in main /home/src/util-linux/text-utils/colcrt.c:141:3 #4 0x7fb0cb2ee60f in __libc_start_main (/usr/lib/libc.so.6+0x2060f) #5 0x4362c8 in _start (/home/src/util-linux/colcrt+0x4362c8) 0x0000013a31f0 is located 0 bytes to the right of global variable 'page' defined in 'text-utils/colcrt.c:73:9' (0x1380b40) of size 140976 SUMMARY: AddressSanitizer: global-buffer-overflow /home/src/util-linux/text-utils/colcrt.c:309 move And another crash: ==4578==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000013a3d24 at pc 0x0000004e2510 bp 0x7ffc9257b0e0 sp 0x7ffc9257b0d8 READ of size 4 at 0x0000013a3d24 thread T0 #0 0x4e250f in colcrt /home/src/util-linux/text-utils/colcrt.c:218:8 #1 0x4e17d4 in main /home/src/util-linux/text-utils/colcrt.c:141:3 #2 0x7fe0ac94160f in __libc_start_main (/usr/lib/libc.so.6+0x2060f) #3 0x4362c8 in _start (/home/src/util-linux/colcrt+0x4362c8) 0x0000013a3d24 is located 8 bytes to the right of global variable 'page' defined in 'text-utils/colcrt.c:73:9' (0x1381240) of size 142044 SUMMARY: AddressSanitizer: global-buffer-overflow /home/src/util-linux/text-utils/colcrt.c:218 colcrt Reported-by: Alaa Mubaied <alaamubaied@gmail.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * colcrt: avoid writing beyond array bound [afl & asan]Sami Kerola2015-08-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | text-utils/colcrt.c:205:10: runtime error: index -1 out of bounds for type 'wchar_t [133]' SUMMARY: AddressSanitizer: undefined-behavior text-utils/colcrt.c:205 ================================================================= ==2357==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000013811b0 at pc 0x0000004e2514 bp 0x7ffdf6ba4450 sp 0x7ffdf6ba4448 READ of size 4 at 0x0000013811b0 thread T0 #0 0x4e2513 in colcrt /home/src/util-linux/text-utils/colcrt.c:213:8 #1 0x4e17d4 in main /home/src/util-linux/text-utils/colcrt.c:139:3 #2 0x7fb77236960f in __libc_start_main (/usr/lib/libc.so.6+0x2060f) #3 0x4362c8 in _start (/home/src/util-linux/colcrt+0x4362c8) Reported-by: Alaa Mubaied <alaamubaied@gmail.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * colcrt: use #define in place of magic constantsSami Kerola2015-08-091-11/+14
| | | | | | | | Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * misc: fix redundant assignment and reassignments before use [cppcheck]Sami Kerola2015-08-083-3/+3
| | | | | | | | Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * tools: stop checkmans.sh validating libtool buildsSami Kerola2015-08-071-1/+1
| | | | | | | | | | | | | | | | The checkmans.sh tried to validate shared libraries, such as ./.libs/libsmartcols.so.1, causing the check output to a have lot of pointless garbage. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* | Merge branch 'patch-1' of https://github.com/borutmrak/util-linuxKarel Zak2015-08-121-2/+6
|\ \ | | | | | | | | | | | | | | | * 'patch-1' of https://github.com/borutmrak/util-linux: mount.8: also note diratime does not override noatime. mount.8: Clarify relation between noatime and nodiratime
| * | mount.8: also note diratime does not override noatime.Borut Mrak2015-08-111-0/+2
| | |
| * | mount.8: Clarify relation between noatime and nodiratimeBorut Mrak2015-08-111-2/+4
| |/ | | | | According to https://lwn.net/Articles/245002/ and checking Linus' git master fs/inode.c it's obvious nodiratime is redundant when mounting with noatime. Clarify that in the man page.
* / lsipc: add more resource to the limits listKarel Zak2015-08-121-12/+23
|/ | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libmount: fix typo in mnt_optstr_prepend_option()Karel Zak2015-08-051-1/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: improve readability [smatch scan]Karel Zak2015-08-051-5/+5
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* misc: fix indention [smatch scan]Karel Zak2015-08-052-2/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* tools: add hexdump badconv() to noreturn smatch listKarel Zak2015-08-051-0/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* more: improve ugly macroKarel Zak2015-08-051-10/+17
| | | | | | no comment, just F*CK YOU to the original author of this crap... Signed-off-by: Karel Zak <kzak@redhat.com>
* libfdisk: (gpt) fix label pointer usage [smatch scan]Karel Zak2015-08-051-1/+3
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libfdisk: remove impossible condition [smatch scan]Karel Zak2015-08-051-3/+0Star
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libfdisk: make context->label usage more robust [smatch scan]Karel Zak2015-08-052-3/+4
|
* libblkid: fix inconsistent indenting [smatch scan]Karel Zak2015-08-052-3/+3
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libmount: variable dereferenced before check [smatch scan]Karel Zak2015-08-051-1/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* cfdisk, sfdisk: remove unused variablesKarel Zak2015-08-052-11/+9Star
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* tools: add err_oom() to smatch no_return_funcsKarel Zak2015-08-051-0/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* lib/blkdev: use 64-bit to count size in bytesKarel Zak2015-08-051-1/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* lib/timeutils: fix indention [smatch scan]Karel Zak2015-08-051-6/+6
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* tailf: fix open() return value check [coverity scan]Karel Zak2015-08-051-1/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* setterm: remove dead code [coverity scan]Karel Zak2015-08-051-2/+0Star
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* agetty: cleanup plymouth usage [coverity scan]Karel Zak2015-08-051-3/+9
| | | | | | | * use macros for paths * check open() return value Signed-off-by: Karel Zak <kzak@redhat.com>
* rtcwake: improve open() usage [coverity scan]Karel Zak2015-08-051-7/+12
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>