summaryrefslogtreecommitdiffstats
path: root/sys-utils
Commit message (Collapse)AuthorAgeFilesLines
* chmem: don't use scanf format for printfRuediger Meier2017-04-101-1/+1
| | | | | | | | | | | The compiler had not complained here because both macros are probably the same. But gettext issued a funny warning: sys-utils/chmem.c:67: warning: Although being used in a format string position, the msgid is not a valid C format string. Reason: The string ends in the middle of a directive. CC: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
* misc: fix some printf format stringsRuediger Meier2017-04-101-4/+4
| | | | | | | | | | | Fix compiler warnings seen on Linux/i586 and OSX/travis. #type #format #cast unsigned long %lu - uint64_t PRIu64 - fdisk_sector_t %ju (uintmax_t) Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
* Merge branch 'hwclock-date7-3' of github.com:jwpi/util-linuxKarel Zak2017-04-045-472/+120Star
|\ | | | | | | | | | | | | | | | | | | * 'hwclock-date7-3' of github.com:jwpi/util-linux: hwclock: remove unused 'silent' arg hwclock: remove dead cmos code hwclock: improve cmos message strings hwclock: remove unused atomic arg in cmos hwclock: remove unused cmos ctl structs hwclock: remove alpha cmos
| * hwclock: remove unused 'silent' argJ William Piggott2017-03-313-14/+10Star
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'silent' argument for get_epoch_rtc() was used to silence error messages when querying the rtc driver for an alpha epoch while using cmos direct access. Alpha cmos has since been removed so 'silent' is no longer used. * sys-utils/hwclock.h: remove 'silent' argument * sys-utils/hwclock.c: same * sys-utils/hwclock-rtc.c: same Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: remove dead cmos codeJ William Piggott2017-03-311-17/+0Star
| | | | | | | | | | | | * hwclock-cmos.c: remove unused 'century' code. Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: improve cmos message stringsJ William Piggott2017-03-311-5/+4Star
| | | | | | | | | | | | * sys-utils/hwclock-cmos.c: improve message strings Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: remove unused atomic arg in cmosJ William Piggott2017-03-311-6/+4Star
| | | | | | | | | | | | * sys-utils/hwclock-cmos.c: remove unused arg for atomic() Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: remove unused cmos ctl structsJ William Piggott2017-03-311-44/+39Star
| | | | | | | | | | | | | | | | | | The hwclock-cmos.c ctl structs were only used for the since removed alpha code. * sys-utils/hwclock-cmos.c: remove unused ctl structs Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: remove alpha cmosJ William Piggott2017-03-314-395/+72Star
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove alpha direct I/O access, use RTC instead: http://marc.info/?l=util-linux-ng&m=141682406902804 Resolves the alpha 2020 issue for util-linux: http://marc.info/?l=util-linux-ng&m=148387021519787 Now it is only the kernel's RTC problem. * sys-utils/hwclock.c: remove alpha cmos * sys-utils/hwclock-cmos.c: same * sys-utils/hwclock.h: same * sys-utils/hwclock.8.in: same Signed-off-by: J William Piggott <elseifthen@gmx.com>
* | Merge branch 'fix-ipcs-shmall-overflow' of ↵Karel Zak2017-04-041-2/+8
|\ \ | | | | | | | | | | | | | | | | | | https://github.com/rudimeier/util-linux * 'fix-ipcs-shmall-overflow' of https://github.com/rudimeier/util-linux: ipcs: make shmall overflow a bit less worse
| * | ipcs: make shmall overflow a bit less worseRuediger Meier2017-04-031-2/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still no large integer support but on overflow we print now the largest possible value, maybe even the largest one which makes sense at all. So on x86_64 systems we'll see now: $ echo "4503599627370496" > /proc/sys/kernel/shmall $ ipcs -m -l | grep "max total" max total shared memory (kbytes) = 18014398509481980 rather than this: $ ipcs -m -l | grep "max total" max total shared memory (kbytes) = 0 Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
* | losetup.8: Reorder options documentationFrederick Grose2017-04-042-48/+44Star
| | | | | | | | | | | | | | | | | | | | | | | | Reorder options to match onboard help and group functionally. Include some missing optional arguments. [kzak@redhat.com: - don't include available columns in man page, - add comments to the usage() - fix order in usage() - fix typo in usage()] Signed-off-by: Karel Zak <kzak@redhat.com>
* | zramctl: be more specific about default outputKarel Zak2017-04-041-3/+3
|/ | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* hwclock: remove 1994 Award BIOS workaroundJ William Piggott2017-03-313-100/+1Star
| | | | | | | | | | | | Remove the 1994 Award BIOS bug workaround as previously discussed more than two years ago: http://marc.info/?l=util-linux-ng&m=141682406902804&w=2 * sys-utils/hwclock.c: remove badyear option * sys-utils/hwclock.h: same * sys-utils/hwclock.8.in: same Signed-off-by: J William Piggott <elseifthen@gmx.com>
* lscpu: fix mem leak [coverity scan]Karel Zak2017-03-311-1/+4
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* lscpu: check return code [coverity scan]Karel Zak2017-03-311-1/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* zramctl: make mm_stat parser more robustKarel Zak2017-03-301-2/+6
| | | | | | | | Let's fallback to attribute files if mm_stat file is incomplete. It should not happen, but I have seen RHEL7 kernel where is no num_migrated/pages_compacted attribute... Signed-off-by: Karel Zak <kzak@redhat.com>
* unshare: add note about persisten PID namespacesKarel Zak2017-03-271-1/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* hwclock-rtc.c: try the 'new' rtc class firstJ William Piggott2017-03-232-5/+5
| | | | | | | * sys-utils/hwclock-rtc.c: try to open the 'new' rtc class driver first. * sys-utils/hwclock.8.in: document this. Signed-off-by: J William Piggott <elseifthen@gmx.com>
* Merge remote-tracking branch 'jwpi/hwclock-date7'Karel Zak2017-03-232-110/+16Star
|\ | | | | | | | | | | | | | | * jwpi/hwclock-date7: lib: add parse-date documentation hwclock: use parse_date function build-sys: add parse-date.y lib: add parse-date.y
| * lib: add parse-date documentationJ William Piggott2017-03-041-11/+11
| | | | | | | | | | | | | | | | * Documentation/parse-date.txt - new file * sys-utils/hwclock.8.in Fix the --date option description. Signed-off-by: J William Piggott <elseifthen@gmx.com>
| * hwclock: use parse_date functionJ William Piggott2017-03-041-99/+5Star
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * hwclock.c: replace interpret_date_string() with parse_date(). Eliminates shell injection vulnerability from popen() date(1). Removes system dependency on date(1). Reduction in hwclock execution time. Significant cleanup of hwclock.c code. * Bug fix for "hwclock --predict --date 'bad_date'" printing: hwclock: No usable set-to time. Cannot set clock. The message now matches date(1) for an invalid --date argument. Signed-off-by: J William Piggott <elseifthen@gmx.com>
* | lscpu: add --jsonKarel Zak2017-03-142-3/+21
| | | | | | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* | lscpu: use libsmartcols to print summary tooKarel Zak2017-03-141-52/+91
|/ | | | | Addresses: https://github.com/karelzak/util-linux/issues/419 Signed-off-by: Karel Zak <kzak@redhat.com>
* unshare: add note about sysfs and procfsKarel Zak2017-02-271-0/+5
| | | | | Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1390057 Signed-off-by: Karel Zak <kzak@redhat.com>
* blkzone: add count option to bash-completionKarel Zak2017-02-241-1/+1
| | | | | | and fix typo in man page Signed-off-by: Karel Zak <kzak@redhat.com>
* blkzone: use optutils.h to check mutually exclusive optionsKarel Zak2017-02-241-6/+13
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* blkzone: Add --count optionDamien Le Moal2017-02-242-39/+76
| | | | | | | | | | | The length option is used to specify the number of zones to operate on. To be more consistent with other tools, have this option use a number of sectors and introduce the --count option to allow users to specify a number of zones. The --count and --length options cannot be used together on the command line. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
* blkzone: Improve zone information printDamien Le Moal2017-02-242-32/+29Star
| | | | | | | | | | | Add "0x" to the zone start, length and write pointer print to make it always clear that the values are Hexadecimal. Also update the zone condition string and associated comments to match more closely the wording in the standard document. The man page is also updated to match the new wording. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
* blkzone: Report all zones if length is not specifiedDamien Le Moal2017-02-241-54/+72
| | | | | | | | | Report all zones of the block device when length is not specified on the command line. To do this, introduce an inner loop in blkzone_report to repeatedly issue report zone ioctl to the device. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
* blkzone: Reset all zones when length is not specifiedDamien Le Moal2017-02-241-3/+5
| | | | | | | If length is 0, operate on all zones starting from offset. This also fix the maximum length calculation from offset. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
* blkreport, blkreset: remove in favour of blkzoneKarel Zak2017-02-235-583/+0Star
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* blkzone: add new command (merge blkreport and blkreset)Karel Zak2017-02-233-0/+460
| | | | | | | This new command is based on the original implementation of blkreport and blkreset command. Signed-off-by: Karel Zak <kzak@redhat.com>
* misc: add static keyword to where needed [smatch scan]Sami Kerola2017-02-208-26/+26
| | | | | | | text-utils/rev.c:68:9: warning: symbol 'buf' was not declared. Should it be static? Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* misc: do not use plain 0 as NULL [smatch scan]Sami Kerola2017-02-2021-283/+283
| | | | | | | | | | text-utils/tailf.c:69:21: warning: Using plain integer as NULL pointer Since many 'struct option' has used zero as NULL make them more readable in same go by reindenting, and using named argument requirements. Reference: https://lwn.net/Articles/93577/ Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* man: improve blkreport(8) and blkreset(8) manual pagesSami Kerola2017-02-132-6/+32
| | | | | | | | Tell in manual page what ZAC and ZBC acronyms mean. Include explanation to blkreport output, so that users do not need to search source code to understand what the tool informed. And fix couple dot double space issues. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* blkreport, blkreset: small code clean upsSami Kerola2017-02-132-35/+25Star
| | | | | | | | | | Set variables read-only where possible. Fix few code style issues, mostly with spacing. Avoid initializing variables if they are never read before next update. Remove "ERR: %d -> %s" message that repeated system error three times, twice in that message and once at end of main that is the only of these three left in place. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* docs: Fix word repetitionsYuri Chornoivan2017-02-139-10/+10
|
* blkreset: remove "LBA" from usage()Karel Zak2017-02-101-2/+3
| | | | | | | * "LBA" sounds confusing Reported-by: Damien Le Moal <damien.lemoal@wdc.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* blkreport: remove "LBA" from usage() and unnecessary alignment checkKarel Zak2017-02-101-6/+1Star
| | | | | | | | | * "LBA" sounds confusing * alignment check is unnecessary for report ioctl Reported-by: Damien Le Moal <damien.lemoal@wdc.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* blkreport: slice up option descriptions, fix typo, fix docstringBenno Schulenberg2017-02-102-18/+14Star
| | | | | | | | | | Each option plus its description should be a separate translatable string. And, if all is well, blkreport should not discard anything -- that is: fix the cut-and-paste error from blkdiscard. Additionally, tweak some wordings. Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
* blkzonecmd, blkreport: Add new commands for ZAC/ZBC drivesShaun Tancheff2017-02-095-0/+575
| | | | | | | | | | | | | | | This patch adds: - blkreset to issue Reset (Write Pointer) zone commands - blkreport to retrieve drive zone information [kzak@redhat.com: - cleanup man page and usage() - remove command line options aliases, - use strtosize_or_err() - remove unnecessary -ludev - use blkdev.h stuff] Signed-off-by: Shaun Tancheff <shaun@tancheff.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* hwclock: remove if-if-conditionKarel Zak2017-02-091-3/+2Star
|
* Merge branch 'hwclock-jwp-reviewed' of ↵Karel Zak2017-02-096-771/+605Star
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://github.com/kerolasa/lelux-utiliteetit * 'hwclock-jwp-reviewed' of git://github.com/kerolasa/lelux-utiliteetit: (25 commits) hwclock: remove --compare option hwclock: remove trailing dot from messages that include system error message hwclock: make --date=argument less prone to injection hwclock: fix rtc atexit registration hwclock: clarify cmos inb and outb preprocessor directives hwclock: try RTCGET and RTCSET only when normal rtc fails hwclock: stream line synchronize_to_clock_tick_rtc() hwclock: improve coding style hwclock: remove division by zero [asan] hwclock: add debugging to open_rtc() hwclock: remove magic constants from interpret_date_string() hwclock: use symbolic magic values passed in between functions hwclock: initialize struct adjtime members hwclock: alloate date_resp parsing buffer in interpret_date_string() hwclock: simplify save_adjtime() execution flow hwclock: remove dead code and other minor fixes hwclock: move error messages to determine_clock_access_method() hwclock: clarify set_cmos_epoch() code hwclock: move command-line options to control structure hwclock: remove unnecessary type casts ...
| * hwclock: remove --compare optionSami Kerola2017-02-053-79/+3Star
| | | | | | | | | | | | | | | | | | | | | | Compare functionality was printing nonsense values. There is no knowledge of anyone using this broken functionality. Instead of deprecating the code for months, and removing it after few release, it is removed immediately. Needless to say this is unusual removal. Reference: http://marc.info/?l=util-linux-ng&m=148396210506652&w=2 Signed-off-by: Karel Zak <kzak@redhat.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * hwclock: remove trailing dot from messages that include system error messageSami Kerola2017-02-052-2/+2
| | | | | | | | Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * hwclock: make --date=argument less prone to injectionSami Kerola2017-02-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | This change should not improve security much. One hopes hwclock --set is restricted for root only. Where hwclock is allowed to run via sudo, or has setuid setup, there is a pretty easy privilege escalation via subshell. $ sudo ./hwclock --set --date='2000-10-20$(touch /tmp/hwclock.inject)' Reviewed-by: J William Piggott <elseifthen@gmx.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * hwclock: fix rtc atexit registrationSami Kerola2017-02-051-1/+1
| | | | | | | | | | | | | | | | Commit 27f9db17bd57b85947445c03e2cd9dda36ca377f missed a minus sign from comparison. Reviewed-by: J William Piggott <elseifthen@gmx.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * hwclock: clarify cmos inb and outb preprocessor directivesSami Kerola2017-02-051-17/+15Star
| | | | | | | | | | | | | | The cmos only works when architecture is i386, x86_64, or alpha. Reviewed-by: J William Piggott <elseifthen@gmx.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
| * hwclock: try RTCGET and RTCSET only when normal rtc failsSami Kerola2017-02-051-21/+23
| | | | | | | | | | | | | | | | | | The RTCGET and RTCSET are in use for sparcs with sbus, so try them as fallback rather than always. Reference: https://github.com/torvalds/linux/blob/master/fs/compat_ioctl.c#L967-L974 Reviewed-by: J William Piggott <elseifthen@gmx.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
generated by cgit v1.2.3-55-g7522 (git 2.39.0) at 2024-07-19 04:38:13 +0200