From 9210c0d225fd808da451d86055bf243a8b47a525 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Mon, 19 Aug 2019 14:03:07 +0200 Subject: chfn: don't append extra tailing commas # grep kzak /etc/passwd kzak:x:1000:1000::/home/kzak:/bin/bash # chfn kzak ... grep kzak /etc/passwd old version: kzak:x:1000:1000:Karel Zak,,,,:/home/kzak:/bin/bash fixed version: kzak:x:1000:1000:Karel Zak:/home/kzak:/bin/bash Reported-by: Filip Dvorak References: f723cbf544a7eac2927634f2cb6d802437a2d519 Signed-off-by: Karel Zak --- login-utils/chfn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/login-utils/chfn.c b/login-utils/chfn.c index a2e6e099e..b7395552b 100644 --- a/login-utils/chfn.c +++ b/login-utils/chfn.c @@ -376,7 +376,7 @@ static int save_new_data(struct chfn_control *ctl) ctl->newf.other); /* remove trailing empty fields (but not subfields of ctl->newf.other) */ - if (!ctl->newf.other) { + if (!ctl->newf.other || !*ctl->newf.other) { while (len > 0 && gecos[len - 1] == ',') len--; gecos[len] = 0; -- cgit v1.2.3-55-g7522