From 06fa5817489adb9728f8a29d4cb7602fb48b8bdb Mon Sep 17 00:00:00 2001 From: Yuriy M. Kaminskiy Date: Sat, 27 Feb 2016 19:27:29 +0300 Subject: misc: safer (and uniform) handling of return value When `rc` is `INT_MAX`, `rc + 1` result in signed integer overflow. Signed-off-by: Karel Zak --- disk-utils/fsck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'disk-utils/fsck.c') diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c index b4630c541..6f9e78b34 100644 --- a/disk-utils/fsck.c +++ b/disk-utils/fsck.c @@ -316,7 +316,7 @@ static int is_irrotational_disk(dev_t disk) "/sys/dev/block/%d:%d/queue/rotational", major(disk), minor(disk)); - if (rc < 0 || (unsigned int) (rc + 1) > sizeof(path)) + if (rc < 0 || (unsigned int) rc >= sizeof(path)) return 0; f = fopen(path, "r"); -- cgit v1.2.3-55-g7522