From fc75981a229a52ee8f5245c4a036dd151e4a70fc Mon Sep 17 00:00:00 2001 From: Yuriy M. Kaminskiy Date: Fri, 8 Apr 2016 00:38:56 +0300 Subject: fsck: fix racing between unlock/unlink and open Process A Process B Process C open() [creates file] lock() [succeed] open() [open existing] lock()... running() close() [...succeed] unlink() running() open() [creates file] {BAD!} lock() [succeed] {BAD!} running() {BAD!} close() Cons: leaves empty (unlocked/harmless) .lock files in /run/fsck/ Signed-off-by: Yuriy M. Kaminskiy --- disk-utils/fsck.c | 1 - 1 file changed, 1 deletion(-) (limited to 'disk-utils/fsck.c') diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c index 05cfbc439..84d2dcc3d 100644 --- a/disk-utils/fsck.c +++ b/disk-utils/fsck.c @@ -410,7 +410,6 @@ static void unlock_disk(struct fsck_instance *inst) printf(_("Unlocking %s.\n"), inst->lockpath); close(inst->lock); /* unlock */ - unlink(inst->lockpath); free(inst->lockpath); -- cgit v1.2.3-55-g7522