From b3f30f50ab726fc5de88c8acc0b3b8e95b9ccb87 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Wed, 27 Mar 2013 14:12:23 +0100 Subject: fsck.cramfs: check returns [coverity scan] Signed-off-by: Karel Zak --- disk-utils/fsck.cramfs.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'disk-utils/fsck.cramfs.c') diff --git a/disk-utils/fsck.cramfs.c b/disk-utils/fsck.cramfs.c index 22e3f46bc..5c4b8c478 100644 --- a/disk-utils/fsck.cramfs.c +++ b/disk-utils/fsck.cramfs.c @@ -170,7 +170,8 @@ static void test_super(int *start, size_t * length) if (get_superblock_endianness(super.magic) != -1) *start = 0; else if (*length >= (PAD_SIZE + sizeof(super))) { - lseek(fd, PAD_SIZE, SEEK_SET); + if (lseek(fd, PAD_SIZE, SEEK_SET) == (off_t) -1) + err(FSCK_EX_ERROR, _("seek failed: %s"), filename); if (read(fd, &super, sizeof(super)) != sizeof(super)) err(FSCK_EX_ERROR, _("read failed: %s"), filename); if (get_superblock_endianness(super.magic) != -1) @@ -226,7 +227,8 @@ static void test_crc(int start) mmap(NULL, super.size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); if (buf != MAP_FAILED) { - lseek(fd, 0, SEEK_SET); + if (lseek(fd, 0, SEEK_SET) == (off_t) -1) + err(FSCK_EX_ERROR, _("seek failed: %s"), filename); if (read(fd, buf, super.size) < 0) err(FSCK_EX_ERROR, _("read failed: %s"), filename); } @@ -241,7 +243,8 @@ static void test_crc(int start) size_t length = 0; buf = xmalloc(4096); - lseek(fd, start, SEEK_SET); + if (lseek(fd, start, SEEK_SET) == (off_t) -1) + err(FSCK_EX_ERROR, _("seek failed: %s"), filename); for (;;) { retval = read(fd, buf, 4096); if (retval < 0) @@ -294,7 +297,8 @@ static void *romfs_read(unsigned long offset) ssize_t x; read_buffer_block = block; - lseek(fd, block << ROMBUFFER_BITS, SEEK_SET); + if (lseek(fd, block << ROMBUFFER_BITS, SEEK_SET) == (off_t) -1) + warn(_("seek failed")); x = read(fd, read_buffer, ROMBUFFERSIZE * 2); if (x < 0) -- cgit v1.2.3-55-g7522