From 9cbf20040b2f8af98dcff0fc889208dde50e3dd4 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 13 Jul 2014 17:36:33 +0100 Subject: mkfs.cramfs: use defined failure name rather than magic value From manual page; 'On error, the value MAP_FAILED is returned, and errno is set appropriately'. Reference: http://man7.org/linux/man-pages/man2/mmap.2.html Signed-off-by: Sami Kerola --- disk-utils/mkfs.cramfs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'disk-utils/mkfs.cramfs.c') diff --git a/disk-utils/mkfs.cramfs.c b/disk-utils/mkfs.cramfs.c index 6f412d888..bae68ecb3 100644 --- a/disk-utils/mkfs.cramfs.c +++ b/disk-utils/mkfs.cramfs.c @@ -167,11 +167,9 @@ do_mmap(char *path, unsigned int size, unsigned int mode){ } start = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); - if (-1 == (int) (long) start) { - close(fd); - err(MKFS_EX_ERROR, "mmap"); - } close(fd); + if (start == MAP_FAILED) + err(MKFS_EX_ERROR, "mmap"); return start; err: free(start); -- cgit v1.2.3-55-g7522