From 6e1eda6f229f87b77471ce6eb7cbf0ede7c8029e Mon Sep 17 00:00:00 2001 From: Ruediger Meier Date: Mon, 19 Jun 2017 20:52:50 +0200 Subject: misc: never use usage(stderr) Here we fix all cases where we have usage(FILE*) functions. Signed-off-by: Ruediger Meier --- disk-utils/partx.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'disk-utils/partx.c') diff --git a/disk-utils/partx.c b/disk-utils/partx.c index 93fbc9c1d..9a868cd81 100644 --- a/disk-utils/partx.c +++ b/disk-utils/partx.c @@ -743,8 +743,9 @@ static blkid_partlist get_partlist(blkid_probe pr, return ls; } -static void __attribute__((__noreturn__)) usage(FILE *out) +static void __attribute__((__noreturn__)) usage(void) { + FILE *out = stdout; size_t i; fputs(USAGE_HEADER, out); @@ -781,7 +782,7 @@ static void __attribute__((__noreturn__)) usage(FILE *out) fprintf(out, USAGE_MAN_TAIL("partx(8)")); - exit(out == stderr ? EXIT_FAILURE : EXIT_SUCCESS); + exit(EXIT_SUCCESS); } int main(int argc, char **argv) @@ -891,7 +892,7 @@ int main(int argc, char **argv) return EXIT_SUCCESS; } case 'h': - usage(stdout); + usage(); case 'V': printf(UTIL_LINUX_VERSION); return EXIT_SUCCESS; @@ -963,9 +964,10 @@ int main(int argc, char **argv) device = NULL; part_devno = 0; } - } else - usage(stderr); - + } else { + warnx(_("bad usage")); + errtryhelp(EXIT_FAILURE); + } if (device && (upper || lower)) errx(EXIT_FAILURE, _("--nr and are mutually exclusive")); -- cgit v1.2.3-55-g7522