From 84f46d1f6725980697e5a442b06ececd9ceb6576 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sat, 18 May 2019 21:46:08 +0100 Subject: sfdisk: remove unnecessary size check [cppcheck] Following warning is false positive. Size of the buffer is defined using BUFSIZ, and so the strncpy() will never overwrite the last byte that is initialized to zero in get_user_reply(). [disk-utils/sfdisk.c:137] -> [disk-utils/sfdisk.c:136]: (warning) Either the condition 'bufsz!=0' is redundant or strncpy() argument nr 3 can have invalid value. The value is -1 but the valid values are '0:'. Signed-off-by: Sami Kerola --- disk-utils/sfdisk.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'disk-utils') diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c index 4a9640d0e..83f3cf8f7 100644 --- a/disk-utils/sfdisk.c +++ b/disk-utils/sfdisk.c @@ -134,8 +134,6 @@ static int get_user_reply(const char *prompt, char *buf, size_t bufsz) if (!p) return 1; strncpy(buf, p, bufsz - 1); - if (bufsz != 0) - buf[bufsz - 1] = '\0'; free(p); } else #endif -- cgit v1.2.3-55-g7522