From 6126f7a53c57485a9a29ddd772765695f23c92e6 Mon Sep 17 00:00:00 2001 From: Petr Uzel Date: Thu, 3 May 2012 21:02:01 +0200 Subject: libuuid: avoid double open and leaking descriptor We are opening /dev/urandom twice in uuid_generate(): first to check if the file is available and then later __uuid_generate_random() again to actually get the random data. Moreover, descriptor from the first open is leaking. Fix by passign the descriptor down the stack and reusing it there. References: http://marc.info/?l=util-linux-ng&m=133406051131131&w=2 Signed-off-by: Petr Uzel --- fdisk/fdiskdoslabel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fdisk') diff --git a/fdisk/fdiskdoslabel.c b/fdisk/fdiskdoslabel.c index 6a9a0445d..c6e4198dd 100644 --- a/fdisk/fdiskdoslabel.c +++ b/fdisk/fdiskdoslabel.c @@ -182,7 +182,7 @@ void create_doslabel(void) unsigned int id; /* random disk signature */ - random_get_bytes(&id, sizeof(id)); + random_get_bytes(&id, sizeof(id), -1); fprintf(stderr, _("Building a new DOS disklabel with disk identifier 0x%08x.\n"), id); -- cgit v1.2.3-55-g7522