From 3999e62a72f46d525ee4cc10b18781468ace9b9c Mon Sep 17 00:00:00 2001 From: Pali Rohár Date: Mon, 20 Nov 2017 18:16:59 +0100 Subject: libblkid: udf: Fix parsing UDF revision UDF revision is stored as decimal number in hexadecimal format. E.g. number 0x0150 is revision 1.50, number 0x0201 is revision 2.01. Apparently all UDF test images have number which has same representation in decimal and hexadecimal format, so problem was not detected. This patch adds new test image with UDF revision 1.50. Internally number is stored as 0x0150. In decimal format it is (incorrectly) 1.80, but in hexadecimal correct 1.50. $ dd if=/dev/zero of=udf-hdd-mkudffs-1.3-8.img bs=1M count=10 $ mkudffs -r 0x150 -b 512 udf-hdd-mkudffs-1.3-8.img Signed-off-by: Pali Rohár --- libblkid/src/superblocks/udf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'libblkid') diff --git a/libblkid/src/superblocks/udf.c b/libblkid/src/superblocks/udf.c index 756fbcf63..bd8e0a5c2 100644 --- a/libblkid/src/superblocks/udf.c +++ b/libblkid/src/superblocks/udf.c @@ -450,7 +450,9 @@ real_blksz: } if (udf_rev) - blkid_probe_sprintf_version(pr, "%d.%02d", (int)(udf_rev >> 8), (int)(udf_rev & 0xFF)); + /* UDF revision is stored as decimal number in hexadecimal format. + * E.g. number 0x0150 is revision 1.50, number 0x0201 is revision 2.01. */ + blkid_probe_sprintf_version(pr, "%x.%02x", (unsigned int)(udf_rev >> 8), (unsigned int)(udf_rev & 0xFF)); return 0; } -- cgit v1.2.3-55-g7522