From e2a0f2634151c36e7dd229db31ee54933bcf28d1 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Wed, 15 May 2019 17:46:31 +0200 Subject: libsmartcols: (groups) improve scols_table_group_lines() args check [coverity scan] Signed-off-by: Karel Zak --- libsmartcols/src/grouping.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'libsmartcols/src') diff --git a/libsmartcols/src/grouping.c b/libsmartcols/src/grouping.c index 0e4851e30..43376fdc7 100644 --- a/libsmartcols/src/grouping.c +++ b/libsmartcols/src/grouping.c @@ -495,11 +495,11 @@ int scols_table_group_lines( struct libscols_table *tb, { struct libscols_group *gr = NULL; - if (!tb || (!ln && !member)) { - DBG(GROUP, ul_debugobj(gr, "failed group lines (no table, line or member)")); + if (!tb || !member) { + DBG(GROUP, ul_debugobj(gr, "failed group lines (no table or member)")); return -EINVAL; } - if (ln && member) { + if (ln) { if (ln->group && !member->group) { DBG(GROUP, ul_debugobj(gr, "failed group lines (new group, line member of another)")); return -EINVAL; -- cgit v1.2.3-55-g7522