From 87918040658f2fa9b1bf78f1f8f4f5c065a2e3a3 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sat, 11 Feb 2017 20:23:26 +0000 Subject: misc: do not use plain 0 as NULL [smatch scan] text-utils/tailf.c:69:21: warning: Using plain integer as NULL pointer Since many 'struct option' has used zero as NULL make them more readable in same go by reindenting, and using named argument requirements. Reference: https://lwn.net/Articles/93577/ Signed-off-by: Sami Kerola --- login-utils/sulogin.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'login-utils/sulogin.c') diff --git a/login-utils/sulogin.c b/login-utils/sulogin.c index 5b8712bfe..b1e8c90f4 100644 --- a/login-utils/sulogin.c +++ b/login-utils/sulogin.c @@ -840,12 +840,12 @@ int main(int argc, char **argv) pid_t pid; static const struct option longopts[] = { - { "login-shell", 0, 0, 'p' }, - { "timeout", 1, 0, 't' }, - { "force", 0, 0, 'e' }, - { "help", 0, 0, 'h' }, - { "version", 0, 0, 'V' }, - { NULL, 0, 0, 0 } + { "login-shell", no_argument, NULL, 'p' }, + { "timeout", required_argument, NULL, 't' }, + { "force", no_argument, NULL, 'e' }, + { "help", no_argument, NULL, 'h' }, + { "version", no_argument, NULL, 'V' }, + { NULL, 0, NULL, 0 } }; INIT_LIST_HEAD(&consoles); -- cgit v1.2.3-55-g7522