From 0f32118e70c097f54fe706cb34adeaf9010a6a7a Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 17 Jul 2016 16:14:16 +0100 Subject: hwclock: use symbolic magic values passed in between functions The manipulate_clock() is seeing return value from busywait_for_rtc_clock_tick(). And the get_permissions_cmos() can see i386_iopl() return value. Reviewed-by: J William Piggott Signed-off-by: Sami Kerola --- sys-utils/hwclock-cmos.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'sys-utils/hwclock-cmos.c') diff --git a/sys-utils/hwclock-cmos.c b/sys-utils/hwclock-cmos.c index 6595725fd..30f8765a5 100644 --- a/sys-utils/hwclock-cmos.c +++ b/sys-utils/hwclock-cmos.c @@ -104,6 +104,8 @@ static int inb(int c __attribute__ ((__unused__))) #define BCD_TO_BIN(val) ((val)=((val)&15) + ((val)>>4)*10) #define BIN_TO_BCD(val) ((val)=(((val)/10)<<4) + (val)%10) +#define IOPL_NOT_IMPLEMENTED -2 + /* * The epoch. * @@ -633,7 +635,7 @@ static int i386_iopl(const int level __attribute__ ((__unused__))) #else static int i386_iopl(const int level __attribute__ ((__unused__))) { - return -2; + return IOPL_NOT_IMPLEMENTED; } #endif @@ -649,7 +651,7 @@ static int get_permissions_cmos(void) rc = 0; } else { rc = i386_iopl(3); - if (rc == -2) { + if (rc == IOPL_NOT_IMPLEMENTED) { warnx(_("I failed to get permission because I didn't try.")); } else if (rc != 0) { rc = errno; -- cgit v1.2.3-55-g7522