From 0bb01bb0b7fc05d7eeb8a0117bc8fbecf54a88ce Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Fri, 5 Sep 2014 23:17:19 +0100 Subject: renice: disallow --priority without pid argument Earlier a lonely priority with an argument but without pid resulted to no action and success, when the invocation should have failed. $ renice --priority 42 ; echo $? 0 Signed-off-by: Sami Kerola --- sys-utils/renice.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sys-utils/renice.c') diff --git a/sys-utils/renice.c b/sys-utils/renice.c index 06056802b..2075d4076 100644 --- a/sys-utils/renice.c +++ b/sys-utils/renice.c @@ -131,14 +131,14 @@ main(int argc, char **argv) } } - if (argc < 2) - usage(stderr); - - if (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0) { + if (*argv && (strcmp(*argv, "-n") == 0 || strcmp(*argv, "--priority") == 0)) { argc--; argv++; } + if (argc < 2) + usage(stderr); + prio = strtol(*argv, &endptr, 10); if (*endptr) usage(stderr); -- cgit v1.2.3-55-g7522