From 88a5f90e874cac53f5d24aed6542d4867be10e2d Mon Sep 17 00:00:00 2001
From: Filipe Brandenburger
Date: Wed, 10 Aug 2016 13:17:12 -0700
Subject: tests: Use proper word splitting when executing tests

Use the shell special variable "$@" instead of the inferior $* to
execute the test command in ts_valgrind.  The expansion of "$@" respects
proper word splitting and makes it possible to pass the command empty
arguments.  It might also prevent surprises with quoting in corner
cases.

Tested that `make check` passes.

Valgrind run with `make check TS_OPTS='--nonroot --memcheck'` passes.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
---
 tests/functions.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'tests/functions.sh')

diff --git a/tests/functions.sh b/tests/functions.sh
index b9a852365..609cedffd 100644
--- a/tests/functions.sh
+++ b/tests/functions.sh
@@ -367,11 +367,11 @@ function ts_init_py {
 
 function ts_valgrind {
 	if [ -z "$TS_VALGRIND_CMD" ]; then
-		$*
+		"$@"
 	else
 		$TS_VALGRIND_CMD --tool=memcheck --leak-check=full \
 				 --leak-resolution=high --num-callers=20 \
-				 --log-file="$TS_VGDUMP" $*
+				 --log-file="$TS_VGDUMP" "$@"
 	fi
 }
 
-- 
cgit v1.2.3-55-g7522