From b1557fe98120132e6671924af4ed69f4e21d3de4 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Tue, 16 May 2017 09:18:24 +0100 Subject: misc: fix ggc-7 fallthrough warnings (Original patch and commit message edited by Rudi.) gcc-7 adds -Wimplicit-fallthrough=3 to our default flag -Wextra. This warning can be silenced by using comment /* fallthrough */ which is also recognized by other tools like coverity. There are also other valid comments (see man gcc-7) but we consolidate this style now. We could have also used __attribute__((fallthrough)) but the comment looks nice and does not need to be ifdef'ed for compatibility. Reference: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652 Reference: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ Reviewed-by: Ruediger Meier Suggested-by: Karel Zak Signed-off-by: Sami Kerola --- text-utils/hexdump-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'text-utils/hexdump-parse.c') diff --git a/text-utils/hexdump-parse.c b/text-utils/hexdump-parse.c index c60a4d06b..2b2735bf7 100644 --- a/text-utils/hexdump-parse.c +++ b/text-utils/hexdump-parse.c @@ -351,7 +351,7 @@ isint: cs[3] = '\0'; case 'A': endfu = fu; fu->flags |= F_IGNORE; - /* FALLTHROUGH */ + /* fallthrough */ case 'a': pr->flags = F_ADDRESS; ++p2; -- cgit v1.2.3-55-g7522