From a3e0b38f607e47588a826cbd7dd04b0c79461a82 Mon Sep 17 00:00:00 2001
From: Jan Darmochwal
Date: Thu, 4 Nov 2010 16:44:40 +0100
Subject: Removed some TODO comments

---
 src/i18n/de.ts   |  2 +-
 src/vsession.cpp | 12 +-----------
 src/vsession.h   | 10 ----------
 src/xsession.h   |  3 ---
 4 files changed, 2 insertions(+), 25 deletions(-)

(limited to 'src')

diff --git a/src/i18n/de.ts b/src/i18n/de.ts
index c81a0fe..b920b73 100644
--- a/src/i18n/de.ts
+++ b/src/i18n/de.ts
@@ -17,7 +17,7 @@
 
 FILE can be a vmware .xml or an X .desktop file
 </source>
-<translation>Aufruf: vmchooser [ OPTIONEN | DATEI ]
+        <translation>Aufruf: vmchooser [ OPTIONEN | DATEI ]
 
   -d, --default   Name der Standardsitzung
   -P, --pool      Name der Umgebung
diff --git a/src/vsession.cpp b/src/vsession.cpp
index f4c2326..e2e359a 100644
--- a/src/vsession.cpp
+++ b/src/vsession.cpp
@@ -54,10 +54,6 @@ QString VSession::getAttribute(const QString &nodeName,
                                 const QString &attribute) const {
     QDomDocument doc = this->doc_;
     QDomNode n = doc.namedItem("eintrag").namedItem(nodeName);
-    if (n.isNull()) {
-        // TODO
-    }
-
     return this->doc_.namedItem("eintrag").namedItem(nodeName).toElement()
             .attribute(attribute);
 }
@@ -155,7 +151,6 @@ void VSession::addPrinters(const QString& script, const QString& type) {
             continue;
         }
 
-        // TODO: check return values, exceptions, ...
         QDomElement printerNode(doc_.createElement(type));
         printerNode.setAttribute("name", tokens.at(1));
         printerNode.setAttribute("path",
@@ -257,11 +252,7 @@ void VSession::mergePoolXml() {
 bool VSession::run() const {
     QString command = getAttribute("command");
     if (!command.isEmpty()) {
-        if (QProcess::startDetached(command)) {
-            // TODO: save session
-            return true;
-        }
-        return false;
+        return QProcess::startDetached(command);
     }
 
     VSession session = *this;
@@ -302,7 +293,6 @@ QList<Session*> VSession::readXmlFile(const QString& filepath) {
     }
     file.close();
 
-    // TODO: iterate over all <settings> child nodes?
     QString dirName(QFileInfo(filepath).dir().absolutePath());
     QDomElement settingsNode = doc.firstChildElement("settings");
     for (QDomElement el(settingsNode.firstChildElement("eintrag"));
diff --git a/src/vsession.h b/src/vsession.h
index 035b235..344b552 100644
--- a/src/vsession.h
+++ b/src/vsession.h
@@ -7,8 +7,6 @@
 #include <QDir>
 #include "session.h"
 
-// TODO: check #includes (in all files)
-
 enum ImgType {
     VMWARE,
     VBOX,
@@ -42,18 +40,10 @@ class VSession : public Session {
                              const QString& attribute = "param") const;
     QString getNodeText(const QString& nodeName) const;
 
-    // TODO: remove next line
-    void addNode(const QString& nodeName);
     void addNodeWithAttribute(const QString& nodeName,
                               const QString& value,
                               const QString& attribute = "param",
                               bool replace = true);
-    // TODO: remove next line
-    void addTODO(const QString& value, const QString& nodeName,
-                 const QString& attribute = "param");
-    // TODO: remove next line
-    void addNodeText(const QString& text, const QString& nodeName);
-
     void addPrinters(const QString& script, const QString& type = "printer");
     void addScanners(const QString& script);
     void addUserAndHostname();
diff --git a/src/xsession.h b/src/xsession.h
index 184b85a..a3aa31b 100644
--- a/src/xsession.h
+++ b/src/xsession.h
@@ -7,9 +7,6 @@
 #include <QDir>
 #include "session.h"
 
-// TODO: check includes (in all files)
-// TODO: sort (operator<)
-
 class XSession : public Session {
   public:
     void init(const QString& name, const QString& exec,
-- 
cgit v1.2.3-55-g7522