summaryrefslogtreecommitdiffstats
path: root/src/server/net
diff options
context:
space:
mode:
authorChristian Klinger2016-05-19 15:55:02 +0200
committerChristian Klinger2016-05-19 15:55:02 +0200
commitc984899f52f11d7148785c9a6cb377b23da87228 (patch)
tree220acd35b0d8b8384437b0de7f4f7c36d742259f /src/server/net
parentadded example switch scripts. (diff)
downloadpvs2-c984899f52f11d7148785c9a6cb377b23da87228.tar.gz
pvs2-c984899f52f11d7148785c9a6cb377b23da87228.tar.xz
pvs2-c984899f52f11d7148785c9a6cb377b23da87228.zip
Closes bug #2807. (And also cleans the code (a bit))
Diffstat (limited to 'src/server/net')
-rw-r--r--src/server/net/client.cpp2
-rw-r--r--src/server/net/discoverylistener.cpp4
2 files changed, 3 insertions, 3 deletions
diff --git a/src/server/net/client.cpp b/src/server/net/client.cpp
index 8a10cd8..e55fb3b 100644
--- a/src/server/net/client.cpp
+++ b/src/server/net/client.cpp
@@ -255,7 +255,7 @@ void Client::handleMsg()
QByteArray hash(_fromClient.getFieldBytes(_HASH));
QByteArray challenge(_fromClient.getFieldBytes(_CHALLENGE));
if (genSha1(&Global::sessionNameArray(), &_challenge) != hash
- && !(Global::getRooms()[Global::getCurrentRoom()]->clientPositions.contains(_socket->peerAddress().toString())))
+ && !(Global::getCurrentRoom()->clientPositions.contains(_socket->peerAddress().toString())))
{ // Challenge reply is invalid, drop client
NetworkMessage msgErr;
msgErr.buildErrorMessage("Challenge reply invalid.");
diff --git a/src/server/net/discoverylistener.cpp b/src/server/net/discoverylistener.cpp
index c5b06fc..c0b80b8 100644
--- a/src/server/net/discoverylistener.cpp
+++ b/src/server/net/discoverylistener.cpp
@@ -159,9 +159,9 @@ void DiscoveryListener::onReadyRead()
if (!Network::isAddressInList(QString::fromUtf8(iplist), addr.toString()))
continue;
// If so, check if the submitted hash seems valid
- if (Global::getCurrentRoom() == "") { continue; }
+ // if (Global::getCurrentRoom() == "") { continue; } // TODO: Can we remove this check?
if (genSha1(&Global::sessionNameArray(), &salt1, &iplist) != hash &&
- !(Global::getRooms()[Global::getCurrentRoom()]->clientPositions.contains(addr.toString())))
+ !(Global::getCurrentRoom()->clientPositions.contains(addr.toString())))
{
// did not match local session name and client is not in same room.
continue;