diff options
| author | Emanuele Giuseppe Esposito | 2022-03-03 16:15:59 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2022-03-04 18:18:25 +0100 |
| commit | 696bf4c78c4640026c827c931a18385b687c66e8 (patch) | |
| tree | d984d5dd358d13399bc5f11cbe1d75437edba816 /block.c | |
| parent | IO_CODE and IO_OR_GS_CODE for block_int I/O API (diff) | |
| download | qemu-696bf4c78c4640026c827c931a18385b687c66e8.tar.gz qemu-696bf4c78c4640026c827c931a18385b687c66e8.tar.xz qemu-696bf4c78c4640026c827c931a18385b687c66e8.zip | |
block: introduce assert_bdrv_graph_writable
We want to be sure that the functions that write the child and
parent list of a bs are under BQL and drain.
BQL prevents from concurrent writings from the GS API, while
drains protect from I/O.
TODO: drains are missing in some functions using this assert.
Therefore a proper assertion will fail. Because adding drains
requires additional discussions, they will be added in future
series.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20220303151616.325444-15-eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
| -rw-r--r-- | block.c | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -1420,6 +1420,7 @@ static void bdrv_child_cb_attach(BdrvChild *child) { BlockDriverState *bs = child->opaque; + assert_bdrv_graph_writable(bs); QLIST_INSERT_HEAD(&bs->children, child, next); if (child->role & BDRV_CHILD_COW) { @@ -1439,6 +1440,7 @@ static void bdrv_child_cb_detach(BdrvChild *child) bdrv_unapply_subtree_drain(child, bs); + assert_bdrv_graph_writable(bs); QLIST_REMOVE(child, next); } @@ -2829,6 +2831,7 @@ static void bdrv_replace_child_noperm(BdrvChild **childp, if (child->klass->detach) { child->klass->detach(child); } + assert_bdrv_graph_writable(old_bs); QLIST_REMOVE(child, next_parent); } @@ -2838,6 +2841,7 @@ static void bdrv_replace_child_noperm(BdrvChild **childp, } if (new_bs) { + assert_bdrv_graph_writable(new_bs); QLIST_INSERT_HEAD(&new_bs->parents, child, next_parent); /* |