diff options
| author | Daniel P. Berrangé | 2022-03-04 20:36:03 +0100 |
|---|---|---|
| committer | Eric Blake | 2022-03-07 22:58:42 +0100 |
| commit | e8ae8b1a75e8f6420c37be31797bd13aa7e95778 (patch) | |
| tree | e8184f49199a8a0ecc046a11c0e293bf3e644eb3 /blockdev-nbd.c | |
| parent | qemu-nbd: add --tls-hostname option for TLS certificate validation (diff) | |
| download | qemu-e8ae8b1a75e8f6420c37be31797bd13aa7e95778.tar.gz qemu-e8ae8b1a75e8f6420c37be31797bd13aa7e95778.tar.xz qemu-e8ae8b1a75e8f6420c37be31797bd13aa7e95778.zip | |
block/nbd: don't restrict TLS usage to IP sockets
The TLS usage for NBD was restricted to IP sockets because validating
x509 certificates requires knowledge of the hostname that the client
is connecting to.
TLS does not have to use x509 certificates though, as PSK (pre-shared
keys) provide an alternative credential option. These have no
requirement for a hostname and can thus be trivially used for UNIX
sockets.
Furthermore, with the ability to overide the default hostname for
TLS validation in the previous patch, it is now also valid to want
to use x509 certificates with FD passing and UNIX sockets.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220304193610.3293146-6-berrange@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'blockdev-nbd.c')
| -rw-r--r-- | blockdev-nbd.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/blockdev-nbd.c b/blockdev-nbd.c index bdfa7ed3a5..9840d25a82 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -148,12 +148,6 @@ void nbd_server_start(SocketAddress *addr, const char *tls_creds, if (!nbd_server->tlscreds) { goto error; } - - /* TODO SOCKET_ADDRESS_TYPE_FD where fd has AF_INET or AF_INET6 */ - if (addr->type != SOCKET_ADDRESS_TYPE_INET) { - error_setg(errp, "TLS is only supported with IPv4/IPv6"); - goto error; - } } nbd_server->tlsauthz = g_strdup(tls_authz); |