diff options
| author | Vladimir Sementsov-Ogievskiy | 2021-01-16 22:47:00 +0100 |
|---|---|---|
| committer | Max Reitz | 2021-01-26 14:36:37 +0100 |
| commit | 6a30f663d4c0b3c45a544d541e0c4e214b2473a1 (patch) | |
| tree | a06a3470d60f54af6f648bdf41ed61538faa18d2 /blockdev.c | |
| parent | backup: move to block-copy (diff) | |
| download | qemu-6a30f663d4c0b3c45a544d541e0c4e214b2473a1.tar.gz qemu-6a30f663d4c0b3c45a544d541e0c4e214b2473a1.tar.xz qemu-6a30f663d4c0b3c45a544d541e0c4e214b2473a1.zip | |
qapi: backup: disable copy_range by default
Further commit will add a benchmark
(scripts/simplebench/bench-backup.py), which will show that backup
works better with async parallel requests (previous commit) and
disabled copy_range. So, let's disable copy_range by default.
Note: the option was added several commits ago with default to true,
to follow old behavior (the feature was enabled unconditionally), and
only now we are going to change the default behavior.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210116214705.822267-19-vsementsov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/blockdev.c b/blockdev.c index 25aaacf253..93417f6302 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2829,7 +2829,7 @@ static BlockJob *do_backup_common(BackupCommon *backup, { BlockJob *job = NULL; BdrvDirtyBitmap *bmap = NULL; - BackupPerf perf = { .use_copy_range = true, .max_workers = 64 }; + BackupPerf perf = { .max_workers = 64 }; int job_flags = JOB_DEFAULT; if (!backup->has_speed) { |