diff options
| author | Markus Armbruster | 2021-11-17 17:34:09 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2021-12-15 14:56:14 +0100 |
| commit | 95fd260f0a3663ed229b8e0d2ef111a9f8bd93ad (patch) | |
| tree | d084871d1762db94f372bedcfc36628aea1e31a5 /blockdev.c | |
| parent | hw/arm/aspeed: Replace drive_get_next() by drive_get() (diff) | |
| download | qemu-95fd260f0a3663ed229b8e0d2ef111a9f8bd93ad.tar.gz qemu-95fd260f0a3663ed229b8e0d2ef111a9f8bd93ad.tar.xz qemu-95fd260f0a3663ed229b8e0d2ef111a9f8bd93ad.zip | |
blockdev: Drop unused drive_get_next()
drive_get_next() is basically a bad idea. It returns the "next" block
backend of a certain interface type. "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.
This lets you define unit numbers implicitly by execution order. If the
order changes, or new calls appear "in the middle", unit numbers change.
ABI break. Hard to spot in review.
The previous commits eliminated all uses. Drop the function.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20211117163409.3587705-14-armbru@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/blockdev.c b/blockdev.c index b35072644e..0eb2823b1b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -303,16 +303,6 @@ int drive_get_max_bus(BlockInterfaceType type) return max_bus; } -/* Get a block device. This should only be used for single-drive devices - (e.g. SD/Floppy/MTD). Multi-disk devices (scsi/ide) should use the - appropriate bus. */ -DriveInfo *drive_get_next(BlockInterfaceType type) -{ - static int next_block_unit[IF_COUNT]; - - return drive_get(type, 0, next_block_unit[type]++); -} - static void bdrv_format_print(void *opaque, const char *name) { qemu_printf(" %s", name); |