diff options
| author | Vladimir Sementsov-Ogievskiy | 2019-06-06 17:41:32 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2019-06-18 16:41:10 +0200 |
| commit | b23c580c946644b906af36e3f903b9fedd6ccd61 (patch) | |
| tree | fd1da098448077b498db94f12df9a1d3aa411b32 /blockdev.c | |
| parent | blockdev: blockdev_mark_auto_del: drop usage of bs->job (diff) | |
| download | qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.tar.gz qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.tar.xz qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.zip | |
block: drop bs->job
Drop remaining users of bs->job:
1. assertions actually duplicated by assert(!bs->refcnt)
2. trace-point seems not enough reason to change stream_start to return
BlockJob pointer
3. Restricting creation of two jobs based on same bs is bad idea, as
3.1 Some jobs creates filters to be their main node, so, this check
don't actually prevent creating second job on same real node (which
will create another filter node) (but I hope it is restricted by
other mechanisms)
3.2 Even without bs->job we have two systems of permissions:
op-blockers and BLK_PERM
3.3 We may want to run several jobs on one node one day
And finally, drop bs->job pointer itself. Hurrah!
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/blockdev.c b/blockdev.c index a9dd73eafc..5d6a13dea9 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3260,7 +3260,7 @@ void qmp_block_stream(bool has_job_id, const char *job_id, const char *device, goto out; } - trace_qmp_block_stream(bs, bs->job); + trace_qmp_block_stream(bs); out: aio_context_release(aio_context); |