diff options
| author | Richard Henderson | 2022-04-17 20:29:43 +0200 |
|---|---|---|
| committer | Richard Henderson | 2022-04-20 19:51:11 +0200 |
| commit | e2c7c6a454c2c4221461aa04e4061dbb91b4986c (patch) | |
| tree | e60843c94e954127b0a92a41099c97a840750fa4 /monitor | |
| parent | target/hexagon: Remove qemu_set_log in hexagon_translate_init (diff) | |
| download | qemu-e2c7c6a454c2c4221461aa04e4061dbb91b4986c.tar.gz qemu-e2c7c6a454c2c4221461aa04e4061dbb91b4986c.tar.xz qemu-e2c7c6a454c2c4221461aa04e4061dbb91b4986c.zip | |
util/log: Return bool from qemu_set_log_filename
Per the recommendations in qapi/error.h, return false on failure.
Use the return value in the monitor, the only place we aren't
already passing error_fatal or error_abort.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220417183019.755276-4-richard.henderson@linaro.org>
Diffstat (limited to 'monitor')
| -rw-r--r-- | monitor/misc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/monitor/misc.c b/monitor/misc.c index b0fc0e5843..4b68fcd346 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -419,8 +419,7 @@ static void hmp_logfile(Monitor *mon, const QDict *qdict) { Error *err = NULL; - qemu_set_log_filename(qdict_get_str(qdict, "filename"), &err); - if (err) { + if (!qemu_set_log_filename(qdict_get_str(qdict, "filename"), &err)) { error_report_err(err); } } |