diff options
| author | Yanan Wang | 2021-09-29 04:58:02 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2021-10-01 15:27:56 +0200 |
| commit | c2511b1632e109130df524121dfb7d2413216d3c (patch) | |
| tree | 57a0a342ab04a4d7a8917b7e7413afbeb6c4226b /qemu-options.hx | |
| parent | qapi/machine: Fix an incorrect comment of SMPConfiguration (diff) | |
| download | qemu-c2511b1632e109130df524121dfb7d2413216d3c.tar.gz qemu-c2511b1632e109130df524121dfb7d2413216d3c.tar.xz qemu-c2511b1632e109130df524121dfb7d2413216d3c.zip | |
machine: Deprecate "parameter=0" SMP configurations
In the SMP configuration, we should either provide a topology
parameter with a reasonable value (greater than zero) or just
omit it and QEMU will compute the missing value.
The users shouldn't provide a configuration with any parameter
of it specified as zero (e.g. -smp 8,sockets=0) which could
possibly cause unexpected results in the -smp parsing. So we
deprecate this kind of configurations since 6.2 by adding the
explicit sanity check.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210929025816.21076-3-wangyanan55@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'qemu-options.hx')
| -rw-r--r-- | qemu-options.hx | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/qemu-options.hx b/qemu-options.hx index ceca52818a..4a092a092a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -233,11 +233,13 @@ SRST of computing the CPU maximum count. Either the initial CPU count, or at least one of the topology parameters - must be specified. Values for any omitted parameters will be computed - from those which are given. Historically preference was given to the - coarsest topology parameters when computing missing values (ie sockets - preferred over cores, which were preferred over threads), however, this - behaviour is considered liable to change. + must be specified. The specified parameters must be greater than zero, + explicit configuration like "cpus=0" is not allowed. Values for any + omitted parameters will be computed from those which are given. + Historically preference was given to the coarsest topology parameters + when computing missing values (ie sockets preferred over cores, which + were preferred over threads), however, this behaviour is considered + liable to change. ERST DEF("numa", HAS_ARG, QEMU_OPTION_numa, |