summaryrefslogtreecommitdiffstats
path: root/stubs
diff options
context:
space:
mode:
authorAlex Bennée2021-10-26 12:22:24 +0200
committerAlex Bennée2021-11-04 11:32:01 +0100
commita00e37a4be88a043fea3e8be3ee3a85f6c4939cf (patch)
treef09dfffdd4e02dd191d2d300ab07b527ca243711 /stubs
parentdocs/tcg-plugins: add L2 arguments to cache docs (diff)
downloadqemu-a00e37a4be88a043fea3e8be3ee3a85f6c4939cf.tar.gz
qemu-a00e37a4be88a043fea3e8be3ee3a85f6c4939cf.tar.xz
qemu-a00e37a4be88a043fea3e8be3ee3a85f6c4939cf.zip
chardev: don't exit() straight away on C-a x
While there are a number of uses in the code-base of the exit(0) pattern it gets in the way of clean exit which can do all of it's house-keeping. In particular it was reported that you can crash plugins this way because TCG can still be running on other threads when the atexit callback is called. Use qmp_quit() instead which takes care of some housekeeping before triggering the shutdown. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reported-by: Lukas Jünger <lukas.junger@greensocs.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20211026102234.3961636-19-alex.bennee@linaro.org>
Diffstat (limited to 'stubs')
-rw-r--r--stubs/meson.build1
-rw-r--r--stubs/qmp-quit.c8
2 files changed, 9 insertions, 0 deletions
diff --git a/stubs/meson.build b/stubs/meson.build
index f6aa3aa94f..71469c1d50 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -31,6 +31,7 @@ stub_ss.add(files('pci-bus.c'))
stub_ss.add(files('qemu-timer-notify-cb.c'))
stub_ss.add(files('qmp_memory_device.c'))
stub_ss.add(files('qmp-command-available.c'))
+stub_ss.add(files('qmp-quit.c'))
stub_ss.add(files('qtest.c'))
stub_ss.add(files('ram-block.c'))
stub_ss.add(files('ramfb.c'))
diff --git a/stubs/qmp-quit.c b/stubs/qmp-quit.c
new file mode 100644
index 0000000000..a3ff47f7bd
--- /dev/null
+++ b/stubs/qmp-quit.c
@@ -0,0 +1,8 @@
+#include "qemu/osdep.h"
+#include "qapi/qapi-commands-control.h"
+#include "qapi/qmp/dispatch.h"
+
+void qmp_quit(Error **errp)
+{
+ g_assert_not_reached();
+}