diff options
author | Nils Schwabe | 2014-07-04 10:31:50 +0200 |
---|---|---|
committer | Nils Schwabe | 2014-07-04 10:31:50 +0200 |
commit | 2d9abf093bbdbfd144314927b0cde1c7f6ca9fe5 (patch) | |
tree | 0932f5cc491dbd6866af4835467a0a17a01e3843 /src/main/java/org/openslx/imagemaster/db | |
parent | Make use of the filetransfer classes (diff) | |
parent | Disable failing test (diff) | |
download | masterserver-2d9abf093bbdbfd144314927b0cde1c7f6ca9fe5.tar.gz masterserver-2d9abf093bbdbfd144314927b0cde1c7f6ca9fe5.tar.xz masterserver-2d9abf093bbdbfd144314927b0cde1c7f6ca9fe5.zip |
Merge branch 'master' of git.openslx.org:bwlp/masterserver
Conflicts:
src/main/java/org/openslx/imagemaster/serverconnection/ImageProcessor.java
Diffstat (limited to 'src/main/java/org/openslx/imagemaster/db')
-rw-r--r-- | src/main/java/org/openslx/imagemaster/db/DbFtpUser.java | 1 | ||||
-rw-r--r-- | src/main/java/org/openslx/imagemaster/db/DbImage.java | 11 | ||||
-rw-r--r-- | src/main/java/org/openslx/imagemaster/db/DbKey.java | 1 |
3 files changed, 7 insertions, 6 deletions
diff --git a/src/main/java/org/openslx/imagemaster/db/DbFtpUser.java b/src/main/java/org/openslx/imagemaster/db/DbFtpUser.java index 088109e..b30f504 100644 --- a/src/main/java/org/openslx/imagemaster/db/DbFtpUser.java +++ b/src/main/java/org/openslx/imagemaster/db/DbFtpUser.java @@ -3,6 +3,7 @@ package org.openslx.imagemaster.db; import java.sql.Timestamp; import java.util.List; +// TODO: Still needed? public class DbFtpUser { diff --git a/src/main/java/org/openslx/imagemaster/db/DbImage.java b/src/main/java/org/openslx/imagemaster/db/DbImage.java index d34fdb3..21d2017 100644 --- a/src/main/java/org/openslx/imagemaster/db/DbImage.java +++ b/src/main/java/org/openslx/imagemaster/db/DbImage.java @@ -89,11 +89,7 @@ public class DbImage */ public static boolean exists( String uuid ) { - if ( MySQL.findUniqueOrNull( DbImage.class, "SELECT images.UUID FROM images WHERE images.UUID = ?", uuid ) == null ) { - return false; - } else { - return true; - } + return getImageByUUID( uuid ) != null; } /** @@ -135,11 +131,14 @@ public class DbImage return this.UUID; } + // TODO: updateLocation? Also make all these update/delete methods non-static, + // so you can call them on an instance you retreived earlier. public static int update( String uuid, String location ) { return MySQL.update( "UPDATE images SET images.image_path = ? WHERE images.UUID = ?", location, uuid ); } + // TODO: Consistency: variable names should be lowerCamelCase public static int updateMissingBlocks( String UUID, List<Integer> missingBlocks) { String missingBlocksList = ""; @@ -166,7 +165,7 @@ public class DbImage } /** - * Creates a package of image data of this DbImage object. + * Creates an instance of the thrift ImageData class of this DbImage object. * @return The corresponding image data */ public ImageData getImageData() { diff --git a/src/main/java/org/openslx/imagemaster/db/DbKey.java b/src/main/java/org/openslx/imagemaster/db/DbKey.java index b57065f..837b9de 100644 --- a/src/main/java/org/openslx/imagemaster/db/DbKey.java +++ b/src/main/java/org/openslx/imagemaster/db/DbKey.java @@ -10,6 +10,7 @@ public class DbKey this.bytes = bytes; } + // TODO: One class per db-table (or per join). This should just be part of DbSatellite public static DbKey fromOrganization(String organization) { return MySQL.findUniqueOrNull( DbKey.class, "SELECT publickey FROM satellite WHERE organization = ?", organization ); } |