diff options
Diffstat (limited to 'src/main/java/org/openslx/imagemaster/Globals.java')
| -rw-r--r-- | src/main/java/org/openslx/imagemaster/Globals.java | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/main/java/org/openslx/imagemaster/Globals.java b/src/main/java/org/openslx/imagemaster/Globals.java index 8fff2d2..3cafdfb 100644 --- a/src/main/java/org/openslx/imagemaster/Globals.java +++ b/src/main/java/org/openslx/imagemaster/Globals.java @@ -33,6 +33,9 @@ public class Globals public static boolean propertiesValid() { + // TODO: Some of these might legitimately be empty (but not null). + // Maybe use Util.notNullFatal on those so you can easily add an error message + // telling which option is missing. Add Util.notNullOrEmptyFatal if you feel like it... if ( getImageDir() == null || getImageDir().isEmpty() || getLdapHost() == null @@ -90,6 +93,9 @@ public class Globals } /* INTEGERS */ + // TODO: Use parseInt not valueOf so we don't instantiate Integers all the time + // TODO: Either way might throw an exception if not parsable as integer. + // Maybe write a Util method that tries Integer.parseInt and returns 0/-1 on exception. public static int getLdapPort() { return Integer.valueOf( properties.getProperty( "ldap_port" ) ); |