diff options
| author | Philippe Mathieu-Daudé | 2021-07-27 16:24:29 +0200 |
|---|---|---|
| committer | Thomas Huth | 2021-07-29 07:56:01 +0200 |
| commit | d3a4e41da25e55b327cc8092f97a6cf02d0b5227 (patch) | |
| tree | 98c77be5c88d69e3b3b9ba1b003f56698746886e /.gitlab-ci.d/buildtest-template.yml | |
| parent | docs: Document GitLab custom CI/CD variables (diff) | |
| download | qemu-d3a4e41da25e55b327cc8092f97a6cf02d0b5227.tar.gz qemu-d3a4e41da25e55b327cc8092f97a6cf02d0b5227.tar.xz qemu-d3a4e41da25e55b327cc8092f97a6cf02d0b5227.zip | |
gitlab-ci: Fix 'when:' condition in acceptance_test_job_template
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: f56bf4caf71 ("gitlab: Run Avocado tests manually (except mainstream CI)")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210727142431.1672530-3-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to '.gitlab-ci.d/buildtest-template.yml')
| -rw-r--r-- | .gitlab-ci.d/buildtest-template.yml | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 3e3e19d96b..fcbcc4e627 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -73,9 +73,9 @@ # in its namespace setting or via git-push option, see documentation # in /.gitlab-ci.yml of this repository). - if: '$CI_PROJECT_NAMESPACE == "qemu-project"' - when: always + when: on_success - if: '$QEMU_CI_AVOCADO_TESTING' - when: always + when: on_success # Otherwise, set to manual (the jobs are created but not run). - when: manual allow_failure: true |