diff options
| author | Mao Zhongyi | 2020-06-03 10:09:00 +0200 |
|---|---|---|
| committer | Dr. David Alan Gilbert | 2020-06-17 18:48:39 +0200 |
| commit | 0705ecc4ade74f03df00e8528987e7876a293f3b (patch) | |
| tree | 57add856e52d184120798272c168fdcf23c5c0bf | |
| parent | monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' f... (diff) | |
| download | qemu-0705ecc4ade74f03df00e8528987e7876a293f3b.tar.gz qemu-0705ecc4ade74f03df00e8528987e7876a293f3b.tar.xz qemu-0705ecc4ade74f03df00e8528987e7876a293f3b.zip | |
monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()
hmp_handle_error() does Error check internally.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Message-Id: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
| -rw-r--r-- | monitor/hmp-cmds.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index a704b3469a..504796d6e9 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1637,9 +1637,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) obj = user_creatable_add_opts(opts, &err); qemu_opts_del(opts); - if (err) { - hmp_handle_error(mon, err); - } + hmp_handle_error(mon, err); + if (obj) { object_unref(obj); } |