diff options
| author | Peter Maydell | 2018-10-30 18:03:53 +0100 |
|---|---|---|
| committer | David Gibson | 2018-11-08 02:04:40 +0100 |
| commit | 09a333ee3dbbc6cdd88830f5b68dc358cacb0093 (patch) | |
| tree | f347237b6dafedf89e9c6c1faff84f806c4ada21 | |
| parent | MAINTAINERS: PPC: Remove myself (diff) | |
| download | qemu-09a333ee3dbbc6cdd88830f5b68dc358cacb0093.tar.gz qemu-09a333ee3dbbc6cdd88830f5b68dc358cacb0093.tar.xz qemu-09a333ee3dbbc6cdd88830f5b68dc358cacb0093.zip | |
hw/ppc/ppc440_uc: Remove dead code in sdram_size()
Coverity points out in CID 1390588 that the test for sh == 0
in sdram_size() can never fire, because we calculate sh with
sh = 1024 - ((bcr >> 6) & 0x3ff);
which must result in a value between 1 and 1024 inclusive.
Without the relevant manual for the SoC, we're not completely
sure of the correct behaviour here, but we can remove the
dead code without changing how QEMU currently behaves.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | hw/ppc/ppc440_uc.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 09ccda548f..9360f781ce 100644 --- a/hw/ppc/ppc440_uc.c +++ b/hw/ppc/ppc440_uc.c @@ -559,11 +559,7 @@ static target_ulong sdram_size(uint32_t bcr) int sh; sh = 1024 - ((bcr >> 6) & 0x3ff); - if (sh == 0) { - size = -1; - } else { - size = 8 * MiB * sh; - } + size = 8 * MiB * sh; return size; } |