diff options
| author | Eric Blake | 2020-10-27 06:05:46 +0100 |
|---|---|---|
| committer | Eric Blake | 2020-10-30 21:10:14 +0100 |
| commit | 159f8442382cff6ef6d858dbf02f03f0cc95b4a7 (patch) | |
| tree | 2d70fc63e16af0666b69b8fcf03fd48a79b0280f | |
| parent | iotests/291: Stop NBD server (diff) | |
| download | qemu-159f8442382cff6ef6d858dbf02f03f0cc95b4a7.tar.gz qemu-159f8442382cff6ef6d858dbf02f03f0cc95b4a7.tar.xz qemu-159f8442382cff6ef6d858dbf02f03f0cc95b4a7.zip | |
block: Simplify QAPI_LIST_ADD
There is no need to rely on the verbosity of the gcc/clang compiler
extension of g_new(typeof(X), 1) when we can instead use the standard
g_malloc(sizeof(X)). In general, we like g_new over g_malloc for
returning type X rather than void* to let the compiler catch more
potential typing mistakes, but in this particular macro, our other use
of typeof on the same line already ensures we are getting correct
results.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20201027050556.269064-2-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | block.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -5240,7 +5240,7 @@ BlockDeviceInfoList *bdrv_named_nodes_list(bool flat, } #define QAPI_LIST_ADD(list, element) do { \ - typeof(list) _tmp = g_new(typeof(*(list)), 1); \ + typeof(list) _tmp = g_malloc(sizeof(*(list))); \ _tmp->value = (element); \ _tmp->next = (list); \ (list) = _tmp; \ |
