diff options
| author | Richard Henderson | 2019-10-22 17:50:35 +0200 |
|---|---|---|
| committer | Peter Maydell | 2019-10-22 17:50:35 +0200 |
| commit | 1ab170865202aab8301131f31bffd87ea0f60d16 (patch) | |
| tree | 5ecf9cdb3df0b9f15253de46e85643e975e77efa | |
| parent | Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191022' into staging (diff) | |
| download | qemu-1ab170865202aab8301131f31bffd87ea0f60d16.tar.gz qemu-1ab170865202aab8301131f31bffd87ea0f60d16.tar.xz qemu-1ab170865202aab8301131f31bffd87ea0f60d16.zip | |
target/arm: Fix sign-extension for SMLAL*
The 32-bit product should be sign-extended, not zero-extended.
Fixes: ea96b374641b
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Message-id: 20190912183058.17947-1-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | target/arm/translate.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/target/arm/translate.c b/target/arm/translate.c index 698c594e8c..96340520ee 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8045,7 +8045,9 @@ static bool op_smlaxxx(DisasContext *s, arg_rrrr *a, case 2: tl = load_reg(s, a->ra); th = load_reg(s, a->rd); - t1 = tcg_const_i32(0); + /* Sign-extend the 32-bit product to 64 bits. */ + t1 = tcg_temp_new_i32(); + tcg_gen_sari_i32(t1, t0, 31); tcg_gen_add2_i32(tl, th, tl, th, t0, t1); tcg_temp_free_i32(t0); tcg_temp_free_i32(t1); |