diff options
| author | John Snow | 2022-07-08 17:34:53 +0200 |
|---|---|---|
| committer | Thomas Huth | 2022-07-18 20:24:36 +0200 |
| commit | 1ab330eae5bc191ed165adc6937fba20ee767b56 (patch) | |
| tree | fb351483d53adb580a38f56668caeb5403d9665e | |
| parent | qga: treat get-guest-fsinfo as "best effort" (diff) | |
| download | qemu-1ab330eae5bc191ed165adc6937fba20ee767b56.tar.gz qemu-1ab330eae5bc191ed165adc6937fba20ee767b56.tar.xz qemu-1ab330eae5bc191ed165adc6937fba20ee767b56.zip | |
tests/vm: use 'cp' instead of 'ln' for temporary vm images
If the initial setup fails, you've permanently altered the state of the
downloaded image in an unknowable way. Use 'cp' like our other test
setup scripts do.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-3-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rwxr-xr-x | tests/vm/centos | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/vm/centos b/tests/vm/centos index 5c7bc1c1a9..be4f6ff2f1 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -34,7 +34,7 @@ class CentosVM(basevm.BaseVM): def build_image(self, img): cimg = self._download_with_cache("https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.3.2011-20201204.2.x86_64.qcow2") img_tmp = img + ".tmp" - subprocess.check_call(["ln", "-f", cimg, img_tmp]) + subprocess.check_call(['cp', '-f', cimg, img_tmp]) self.exec_qemu_img("resize", img_tmp, "50G") self.boot(img_tmp, extra_args = ["-cdrom", self.gen_cloud_init_iso()]) self.wait_ssh() |