summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Gibson2015-07-02 08:23:06 +0200
committerAlexander Graf2015-07-07 17:44:50 +0200
commit1b71890729953825c57d52ace48a7671c295e899 (patch)
tree2a01bc02d965833c834e604b7480da0ad1c7cc19
parentspapr: Remove obsolete ram_limit field from sPAPRMachineState (diff)
downloadqemu-1b71890729953825c57d52ace48a7671c295e899.tar.gz
qemu-1b71890729953825c57d52ace48a7671c295e899.tar.xz
qemu-1b71890729953825c57d52ace48a7671c295e899.zip
spapr: Remove obsolete entry_point field from sPAPRMachineState
The sPAPRMachineState structure includes an entry_point field containing the initial PC value for starting the machine, even though this always has the value 0x100. I think this is a hangover from very early versions which bypassed the firmware when using -kernel. In any case it has no function now, so remove it. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Alexander Graf <agraf@suse.de>
-rw-r--r--hw/ppc/spapr.c4
-rw-r--r--include/hw/ppc/spapr.h2
2 files changed, 2 insertions, 4 deletions
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 6adfb68c31..3aeb2ead2a 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -932,7 +932,7 @@ static void ppc_spapr_reset(void)
first_ppc_cpu->env.gpr[3] = spapr->fdt_addr;
first_ppc_cpu->env.gpr[5] = 0;
first_cpu->halted = 0;
- first_ppc_cpu->env.nip = spapr->entry_point;
+ first_ppc_cpu->env.nip = SPAPR_ENTRY_POINT;
}
@@ -1645,8 +1645,6 @@ static void ppc_spapr_init(MachineState *machine)
}
g_free(filename);
- spapr->entry_point = 0x100;
-
/* FIXME: Should register things through the MachineState's qdev
* interface, this is a legacy from the sPAPREnvironment structure
* which predated MachineState but had a similar function */
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 9e7cf0fcbd..785b0944d9 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -13,6 +13,7 @@ typedef struct sPAPRConfigureConnectorState sPAPRConfigureConnectorState;
typedef struct sPAPREventLogEntry sPAPREventLogEntry;
#define HPTE64_V_HPTE_DIRTY 0x0000000000000040ULL
+#define SPAPR_ENTRY_POINT 0x100
typedef struct sPAPRMachineState sPAPRMachineState;
@@ -41,7 +42,6 @@ struct sPAPRMachineState {
ssize_t rtas_size;
void *rtas_blob;
void *fdt_skel;
- target_ulong entry_point;
uint64_t rtc_offset; /* Now used only during incoming migration */
struct PPCTimebase tb;
bool has_graphics;