diff options
| author | Max Reitz | 2021-01-18 11:57:18 +0100 |
|---|---|---|
| committer | Max Reitz | 2021-01-26 14:36:37 +0100 |
| commit | 20c15f7c5248ae75df9c6f7b5b1433632420eda9 (patch) | |
| tree | 6d9ea7679618a2f4c74ba6f2b5e05ef3c22e63b0 | |
| parent | iotests/129: Actually test a commit job (diff) | |
| download | qemu-20c15f7c5248ae75df9c6f7b5b1433632420eda9.tar.gz qemu-20c15f7c5248ae75df9c6f7b5b1433632420eda9.tar.xz qemu-20c15f7c5248ae75df9c6f7b5b1433632420eda9.zip | |
iotests/129: Limit mirror job's buffer size
Issuing 'stop' on the VM drains all nodes. If the mirror job has many
large requests in flight, this may lead to significant I/O that looks a
bit like 'stop' would make the job try to complete (which is what 129
should verify not to happen).
We can limit the I/O in flight by limiting the buffer size, so mirror
will make very little progress during the 'stop' drain.
(We do not need to do anything about commit, which has a buffer size of
512 kB by default; or backup, which goes cluster by cluster. Once we
have asynchronous requests for backup, that will change, but then we can
fine-tune the backup job to only perform a single request on a very
small chunk, too.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210118105720.14824-9-mreitz@redhat.com>
| -rwxr-xr-x | tests/qemu-iotests/129 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 index f4b447b04a..03843fc255 100755 --- a/tests/qemu-iotests/129 +++ b/tests/qemu-iotests/129 @@ -68,7 +68,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase): def test_drive_mirror(self): self.do_test_stop("drive-mirror", device="drive0", target=self.target_img, format=iotests.imgfmt, - sync="full") + sync="full", buf_size=65536) def test_drive_backup(self): self.do_test_stop("drive-backup", device="drive0", |