diff options
| author | Sorav Bansal | 2014-06-17 07:54:02 +0200 |
|---|---|---|
| committer | Alexander Graf | 2014-06-27 13:48:22 +0200 |
| commit | 294d1292893867894992e810a01cfcfa451f1885 (patch) | |
| tree | 044562b200d387b9140e5939774069b687e53b16 | |
| parent | spapr: Add "qemu, boot-menu" property to /chosen (diff) | |
| download | qemu-294d1292893867894992e810a01cfcfa451f1885.tar.gz qemu-294d1292893867894992e810a01cfcfa451f1885.tar.xz qemu-294d1292893867894992e810a01cfcfa451f1885.zip | |
target-ppc: fixed translation of mcrxr instruction
Fixed bug in gen_mcrxr() in target-ppc/translate.c:
The XER[SO], XER[OV], and XER[CA] flags are stored in the least
significant bit (bit 0) of their respective registers. They need
to be shifted left (by their respective offsets) to generate the final
XER value. The old translation code for the 'mcrxr' instruction
was assuming that the flags are stored in bit 2, and was shifting them
right (incorrectly)
Signed-off-by: Sorav Bansal <sbansal@cse.iitd.ernet.in>
Reviewed-by: Tom Musta <tommusta@gmail.com>
Tested-by: Tom Musta <tommusta@gmail.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
| -rw-r--r-- | target-ppc/translate.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 48017219a4..c5d73d5aa0 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -4123,8 +4123,9 @@ static void gen_mcrxr(DisasContext *ctx) tcg_gen_trunc_tl_i32(t0, cpu_so); tcg_gen_trunc_tl_i32(t1, cpu_ov); tcg_gen_trunc_tl_i32(dst, cpu_ca); - tcg_gen_shri_i32(t0, t0, 2); - tcg_gen_shri_i32(t1, t1, 1); + tcg_gen_shli_i32(t0, t0, 3); + tcg_gen_shli_i32(t1, t1, 2); + tcg_gen_shli_i32(dst, dst, 1); tcg_gen_or_i32(dst, dst, t0); tcg_gen_or_i32(dst, dst, t1); tcg_temp_free_i32(t0); |