diff options
| author | Greg Kurz | 2020-05-14 00:57:13 +0200 |
|---|---|---|
| committer | David Gibson | 2020-05-27 07:29:36 +0200 |
| commit | 31efae9958a8a085d248a74a9448048bac5d6e68 (patch) | |
| tree | b5b9a1b7aadfb7e8dac7c564469df48de7ecd427 | |
| parent | target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate() (diff) | |
| download | qemu-31efae9958a8a085d248a74a9448048bac5d6e68.tar.gz qemu-31efae9958a8a085d248a74a9448048bac5d6e68.tar.xz qemu-31efae9958a8a085d248a74a9448048bac5d6e68.zip | |
target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
The last two arguments have the bool type. Also, we shouldn't raise an
exception when using gdbstub.
This was found while reading the code. Since it only affects the powernv
machine, I didn't dig further to find an actual bug.
Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation"
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <158941063281.240484.9114539141307005992.stgit@bahia.lan>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | target/ppc/mmu-radix64.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c index fb7dfe25ba..7ce37cb778 100644 --- a/target/ppc/mmu-radix64.c +++ b/target/ppc/mmu-radix64.c @@ -339,7 +339,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU *cpu, int rwx, */ ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, prtbe_addr, pate, &h_raddr, &h_prot, - &h_page_size, 1, 1); + &h_page_size, true, + cause_excp); if (ret) { return ret; } @@ -378,7 +379,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU *cpu, int rwx, do { ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, pte_addr, pate, &h_raddr, &h_prot, - &h_page_size, 1, 1); + &h_page_size, true, + cause_excp); if (ret) { return ret; } |