diff options
| author | Emilio G. Cota | 2018-08-18 00:15:33 +0200 |
|---|---|---|
| committer | Richard Henderson | 2018-09-26 17:55:54 +0200 |
| commit | 321a33f534eb0285f483a2db5f4b47442adadd87 (patch) | |
| tree | 1a6405db19d6346b7c5c7b9fdf59f2cb12deeaf1 | |
| parent | test-qht: test removal of non-existent entries (diff) | |
| download | qemu-321a33f534eb0285f483a2db5f4b47442adadd87.tar.gz qemu-321a33f534eb0285f483a2db5f4b47442adadd87.tar.xz qemu-321a33f534eb0285f483a2db5f4b47442adadd87.zip | |
test-qht: test deletion of the last entry in a bucket
This improves coverage by one (!) LoC in qht.c, bringing the
coverage rate up from 90.00% to 90.28%.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | tests/test-qht.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/tests/test-qht.c b/tests/test-qht.c index 05b1d6807a..77666e8c5f 100644 --- a/tests/test-qht.c +++ b/tests/test-qht.c @@ -172,9 +172,20 @@ static void qht_do_test(unsigned int mode, size_t init_entries) qht_init(&ht, is_equal, 0, mode); rm_nonexist(0, 4); + /* + * Test that we successfully delete the last element in a bucket. + * This is a hard-to-reach code path when resizing is on, but without + * resizing we can easily hit it if init_entries <= 1. + * Given that the number of elements per bucket can be 4 or 6 depending on + * the host's pointer size, test the removal of the 4th and 6th elements. + */ insert(0, 4); rm_nonexist(5, 6); - insert(4, 6); + rm(3, 4); + check_n(3); + insert(3, 6); + rm(5, 6); + check_n(5); rm_nonexist(7, 8); iter_rm_mod(1); |
