diff options
| author | Eric Blake | 2018-01-11 00:08:22 +0100 |
|---|---|---|
| committer | Eric Blake | 2018-01-18 03:14:12 +0100 |
| commit | 32f158a63509656f95922ce28d1b4a4e06a2cbf2 (patch) | |
| tree | a51e07813e3a8ded72da3e148716fec3e0c8a142 | |
| parent | nbd/server: refactor negotiation functions parameters (diff) | |
| download | qemu-32f158a63509656f95922ce28d1b4a4e06a2cbf2.tar.gz qemu-32f158a63509656f95922ce28d1b4a4e06a2cbf2.tar.xz qemu-32f158a63509656f95922ce28d1b4a4e06a2cbf2.zip | |
nbd/server: Better error for NBD_OPT_EXPORT_NAME failure
When a client abruptly disconnects before we've finished reading
the name sent with NBD_OPT_EXPORT_NAME, we are better off logging
the failure as EIO (we can't communicate with the client), rather
than EINVAL (the client sent bogus data).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20180110230825.18321-4-eblake@redhat.com>
| -rw-r--r-- | nbd/server.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/nbd/server.c b/nbd/server.c index b9efdcc605..31c1d32429 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -299,7 +299,7 @@ static int nbd_negotiate_handle_export_name(NBDClient *client, } if (nbd_read(client->ioc, name, client->optlen, errp) < 0) { error_prepend(errp, "read failed: "); - return -EINVAL; + return -EIO; } name[client->optlen] = '\0'; client->optlen = 0; |