summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRao, Lei2020-10-16 07:52:00 +0200
committerJason Wang2020-11-11 09:52:23 +0100
commit33609e95b206788681263b76d6649a556d064e4d (patch)
tree9fd541e4ecb158ebf187a51dc779278c080f85a6
parentnet/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup (diff)
downloadqemu-33609e95b206788681263b76d6649a556d064e4d.tar.gz
qemu-33609e95b206788681263b76d6649a556d064e4d.tar.xz
qemu-33609e95b206788681263b76d6649a556d064e4d.zip
Optimize seq_sorter function for colo-compare
The seq of tcp has been filled in fill_pkt_tcp_info, it can be used directly here. Signed-off-by: Lei Rao <lei.rao@intel.com> Signed-off-by: Zhang Chen <chen.zhang@intel.com> Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com> Reviewed-by: Zhang Chen <chen.zhang@intel.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
-rw-r--r--net/colo-compare.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 3a45d64175..a35c10fb59 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -194,13 +194,10 @@ static void colo_compare_inconsistency_notify(CompareState *s)
}
}
+/* Use restricted to colo_insert_packet() */
static gint seq_sorter(Packet *a, Packet *b, gpointer data)
{
- struct tcp_hdr *atcp, *btcp;
-
- atcp = (struct tcp_hdr *)(a->transport_header);
- btcp = (struct tcp_hdr *)(b->transport_header);
- return ntohl(atcp->th_seq) - ntohl(btcp->th_seq);
+ return a->tcp_seq - b->tcp_seq;
}
static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)