diff options
| author | Pavel Dovgalyuk | 2018-09-20 09:17:03 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2018-10-02 19:09:13 +0200 |
| commit | 41d54dc09f1f327dedc79d5ba0b1b437ab7b0e94 (patch) | |
| tree | 61c849b1ba92a9dec077438911596a8ac4453208 | |
| parent | hvf: drop unused variable (diff) | |
| download | qemu-41d54dc09f1f327dedc79d5ba0b1b437ab7b0e94.tar.gz qemu-41d54dc09f1f327dedc79d5ba0b1b437ab7b0e94.tar.xz qemu-41d54dc09f1f327dedc79d5ba0b1b437ab7b0e94.zip | |
target/i386: fix translation for icount mode
This patch fixes the checking of boundary crossing instructions.
In icount mode only first instruction of the block may cross
the page boundary to keep the translation deterministic.
These conditions already existed, but compared the wrong variable.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Message-Id: <20180920071702.22477.43980.stgit@pasha-VirtualBox>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/translate.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/target/i386/translate.c b/target/i386/translate.c index 8fcd88e326..83c1ebe491 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -8538,10 +8538,10 @@ static void i386_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu) chance to happen */ dc->base.is_jmp = DISAS_TOO_MANY; } else if ((tb_cflags(dc->base.tb) & CF_USE_ICOUNT) - && ((dc->base.pc_next & TARGET_PAGE_MASK) - != ((dc->base.pc_next + TARGET_MAX_INSN_SIZE - 1) + && ((pc_next & TARGET_PAGE_MASK) + != ((pc_next + TARGET_MAX_INSN_SIZE - 1) & TARGET_PAGE_MASK) - || (dc->base.pc_next & ~TARGET_PAGE_MASK) == 0)) { + || (pc_next & ~TARGET_PAGE_MASK) == 0)) { /* Do not cross the boundary of the pages in icount mode, it can cause an exception. Do it only when boundary is crossed by the first instruction in the block. |