summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFilip Bozuta2020-08-11 18:45:52 +0200
committerLaurent Vivier2020-08-27 12:29:50 +0200
commit45f567994c2f0272cede9956ed0ea0d8a6294495 (patch)
tree4c12cb546ff797124a364ad69c5f0d5698298d4b
parentlinux-user: Add strace support for printing arguments of syscalls used to loc... (diff)
downloadqemu-45f567994c2f0272cede9956ed0ea0d8a6294495.tar.gz
qemu-45f567994c2f0272cede9956ed0ea0d8a6294495.tar.xz
qemu-45f567994c2f0272cede9956ed0ea0d8a6294495.zip
linux-user: Add an api to print enumareted argument values with strace
This patch introduces a type 'struct enums' and function 'print_enums()' that can be used to print enumerated argument values of some syscalls in strace. This can be used in future strace implementations. Also, macros 'ENUM_GENERIC()', 'ENUM_TARGET()' and 'ENUM_END', are introduced to enable automatic generation of aproppriate enumarated values and their repsective string representations (these macros are exactly the same as 'FLAG_GENERIC()', 'FLAG_TARGET()' and 'FLAG_END'). Future patches are planned to modify all existing print functions in 'strace.c' that print arguments of syscalls with enumerated values to use this new api. Signed-off-by: Filip Bozuta <Filip.Bozuta@syrmia.com> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20200811164553.27713-5-Filip.Bozuta@syrmia.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
-rw-r--r--linux-user/strace.c31
1 files changed, 31 insertions, 0 deletions
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 4ac54ecffe..d0731b888d 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -52,9 +52,23 @@ struct flags {
/* end of flags array */
#define FLAG_END { 0, NULL }
+/* Structure used to translate enumerated values into strings */
+struct enums {
+ abi_long e_value; /* enum value */
+ const char *e_string; /* stringified enum */
+};
+
+/* common enums for all architectures */
+#define ENUM_GENERIC(name) { name, #name }
+/* target specific enums */
+#define ENUM_TARGET(name) { TARGET_ ## name, #name }
+/* end of enums array */
+#define ENUM_END { 0, NULL }
+
UNUSED static const char *get_comma(int);
UNUSED static void print_pointer(abi_long, int);
UNUSED static void print_flags(const struct flags *, abi_long, int);
+UNUSED static void print_enums(const struct enums *, abi_long, int);
UNUSED static void print_at_dirfd(abi_long, int);
UNUSED static void print_file_mode(abi_long, int);
UNUSED static void print_open_flags(abi_long, int);
@@ -1253,6 +1267,23 @@ print_flags(const struct flags *f, abi_long flags, int last)
}
static void
+print_enums(const struct enums *e, abi_long enum_arg, int last)
+{
+ for (; e->e_string != NULL; e++) {
+ if (e->e_value == enum_arg) {
+ qemu_log("%s", e->e_string);
+ break;
+ }
+ }
+
+ if (e->e_string == NULL) {
+ qemu_log("%#x", (unsigned int)enum_arg);
+ }
+
+ qemu_log("%s", get_comma(last));
+}
+
+static void
print_at_dirfd(abi_long dirfd, int last)
{
#ifdef AT_FDCWD