diff options
| author | Eric Blake | 2018-11-30 03:32:31 +0100 |
|---|---|---|
| committer | Eric Blake | 2018-11-30 21:11:20 +0100 |
| commit | 47829c40794160debdb33b4a042d182e776876d4 (patch) | |
| tree | f930cfaed80247e2c3424b5722aed0767bef5a0a | |
| parent | nbd/server: Advertise all contexts in response to bare LIST (diff) | |
| download | qemu-47829c40794160debdb33b4a042d182e776876d4.tar.gz qemu-47829c40794160debdb33b4a042d182e776876d4.tar.xz qemu-47829c40794160debdb33b4a042d182e776876d4.zip | |
nbd/client: Make x-dirty-bitmap more reliable
The implementation of x-dirty-bitmap in qemu 3.0 (commit 216ee365)
silently falls back to treating the server as not supporting
NBD_CMD_BLOCK_STATUS if a requested meta_context name was not
negotiated, which in turn means treating the _entire_ image as
data. Since our hack relied on using 'qemu-img map' to view
which portions of the image were dirty by seeing what the
redirected bdrv_block_status() treats as holes, this means
that our fallback treats the entire image as clean. Better
would have been to treat the entire image as dirty, or to fail
to connect because the user's request for a specific context
could not be honored. This patch goes with the latter.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181130023232.3079982-3-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
| -rw-r--r-- | block/nbd-client.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/block/nbd-client.c b/block/nbd-client.c index 76e9ca3abe..e6e27dafa6 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@ -992,6 +992,11 @@ int nbd_client_init(BlockDriverState *bs, logout("Failed to negotiate with the NBD server\n"); return ret; } + if (x_dirty_bitmap && !client->info.base_allocation) { + error_setg(errp, "requested x-dirty-bitmap %s not found", + x_dirty_bitmap); + return -EINVAL; + } if (client->info.flags & NBD_FLAG_READ_ONLY) { ret = bdrv_apply_auto_read_only(bs, "NBD export is read-only", errp); if (ret < 0) { |