diff options
| author | Markus Armbruster | 2014-03-06 10:12:53 +0100 |
|---|---|---|
| committer | Andreas Färber | 2014-03-12 20:13:02 +0100 |
| commit | 49649f23db977137c031a21eee2f0521404f6710 (patch) | |
| tree | 69e9d6d7e4cde67cea2514f9c456e07ab234a7bc | |
| parent | qdev-monitor-test: Simplify using g_assert_cmpstr() (diff) | |
| download | qemu-49649f23db977137c031a21eee2f0521404f6710.tar.gz qemu-49649f23db977137c031a21eee2f0521404f6710.tar.xz qemu-49649f23db977137c031a21eee2f0521404f6710.zip | |
qdev-monitor-test: Don't test human-readable error message
Test the error class instead. Expecting a specific message is
fragile. In fact, it broke once already, in commit 75884af. Restore
the test of error member "class" dropped there, and drop the test of
error member "desc".
There are no other tests of "desc" as far as I can tell.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
| -rw-r--r-- | tests/qdev-monitor-test.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c index eefaab823a..e20ffd67a7 100644 --- a/tests/qdev-monitor-test.c +++ b/tests/qdev-monitor-test.c @@ -32,9 +32,7 @@ static void test_device_add(void) "}}"); g_assert(response); error = qdict_get_qdict(response, "error"); - g_assert_cmpstr(qdict_get_try_str(error, "desc"), - ==, - "Device needs media, but drive is empty"); + g_assert_cmpstr(qdict_get_try_str(error, "class"), ==, "GenericError"); QDECREF(response); /* Delete the drive */ |