diff options
| author | Richard Henderson | 2022-09-20 13:09:45 +0200 |
|---|---|---|
| committer | Richard Henderson | 2022-10-26 03:11:28 +0200 |
| commit | 4c88475c9fe501b5c886a963647670f929c65400 (patch) | |
| tree | 61e360d946153cb3fda053dbdd380843386a985b | |
| parent | accel/tcg: Drop cpu_get_tb_cpu_state from TARGET_HAS_PRECISE_SMC (diff) | |
| download | qemu-4c88475c9fe501b5c886a963647670f929c65400.tar.gz qemu-4c88475c9fe501b5c886a963647670f929c65400.tar.xz qemu-4c88475c9fe501b5c886a963647670f929c65400.zip | |
accel/tcg: Remove duplicate store to tb->page_addr[]
When we added the fast path, we initialized page_addr[] early.
These stores in and around tb_page_add() are redundant; remove them.
Fixes: 50627f1b7b1 ("accel/tcg: Add fast path for translator_ld*")
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | accel/tcg/tb-maint.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index 9af5cb49e0..7f4e1e1299 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -405,7 +405,6 @@ static inline void tb_page_add(PageDesc *p, TranslationBlock *tb, assert_page_locked(p); - tb->page_addr[n] = page_addr; tb->page_next[n] = p->first_tb; #ifndef CONFIG_USER_ONLY page_already_protected = p->first_tb != (uintptr_t)NULL; @@ -461,8 +460,6 @@ TranslationBlock *tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc, tb_page_add(p, tb, 0, phys_pc); if (p2) { tb_page_add(p2, tb, 1, phys_page2); - } else { - tb->page_addr[1] = -1; } /* add in the hash table */ |