summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yang2019-04-24 02:46:57 +0200
committerDr. David Alan Gilbert2019-05-14 18:33:35 +0200
commit5351e69af826665cef6858c960c3336a4228bb70 (patch)
tree9cd5be22a2ac209fcf0228287732bc049e6cb902
parentmigration: update comments of migration bitmap (diff)
downloadqemu-5351e69af826665cef6858c960c3336a4228bb70.tar.gz
qemu-5351e69af826665cef6858c960c3336a4228bb70.tar.xz
qemu-5351e69af826665cef6858c960c3336a4228bb70.zip
migration/savevm: remove duplicate check of migration_is_blocked
Current call flow of save_snapshot is: save_snapshot migration_is_blocked qemu_savevm_state migration_is_blocked Since qemu_savevm_state is only called in save_snapshot, this means migration_is_blocked has been already checked. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Message-Id: <20190424004700.12766-2-richardw.yang@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
-rw-r--r--migration/savevm.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/migration/savevm.c b/migration/savevm.c
index 81a9a2ef30..6e8912af49 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1418,10 +1418,6 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
return -EINVAL;
}
- if (migration_is_blocked(errp)) {
- return -EINVAL;
- }
-
if (migrate_use_block()) {
error_setg(errp, "Block migration and snapshots are incompatible");
return -EINVAL;